Attention is currently required from: Furquan Shaikh, Tony Huang, Keith Tzeng, Wisley Chen.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52847 )
Change subject: drivers/i2c/generic: Set SW0 to 3 for wake device
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52847/comment/15a1de0c_8103a4f6
PS1, Line 9: 3
Only because this commit impacts many boards can you elaborate a little more why `3` and not `4` to help if someone does need to bisect back to this for their board.
File src/drivers/i2c/generic/generic.c:
https://review.coreboot.org/c/coreboot/+/52847/comment/9fc7b4b0_7d07adcd
PS1, Line 101: 3);
please update `Documentation/acpi/devicetree.md` as well.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52847
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I34e4b2350875530d3337be700276bcc4fb1f810a
Gerrit-Change-Number: 52847
Gerrit-PatchSet: 1
Gerrit-Owner: Tony Huang
tony-huang@quanta.corp-partner.google.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Keith Tzeng
keith.tzeng@quanta.corp-partner.google.com
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-Reviewer: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tony Huang
tony-huang@quanta.corp-partner.google.com
Gerrit-Attention: Keith Tzeng
keith.tzeng@quanta.corp-partner.google.com
Gerrit-Attention: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Comment-Date: Mon, 03 May 2021 05:44:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment