Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40873 )
Change subject: mb/purism/librem_skl: disable serial console by default ......................................................................
mb/purism/librem_skl: disable serial console by default
Librem SKL/KBL boards do not have an exposed serial port interface. Set board Kconfig so that a default built image with Tianocore payload is bootable and doesn't hang due to trying to send data over a non-existant serial port.
Test: build/boot librem 13v4 with board defaults + Tianocore
Signed-off-by: Matt DeVillier matt.devillier@puri.sm Change-Id: I4c3f8a3c1726f804957b06b437b399291854a3f5 --- M src/mainboard/purism/librem_skl/Kconfig 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/40873/1
diff --git a/src/mainboard/purism/librem_skl/Kconfig b/src/mainboard/purism/librem_skl/Kconfig index ca1582a..4f51d9e 100644 --- a/src/mainboard/purism/librem_skl/Kconfig +++ b/src/mainboard/purism/librem_skl/Kconfig @@ -73,4 +73,8 @@ config NO_POST default y
+config CONSOLE_SERIAL + bool + default n + endif
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40873 )
Change subject: mb/purism/librem_skl: disable serial console by default ......................................................................
Patch Set 1:
If UART is not even an option. Shouldn't we select NO_UART_ON_SUPERIO?
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40873 )
Change subject: mb/purism/librem_skl: disable serial console by default ......................................................................
Patch Set 1:
Patch Set 1:
If UART is not even an option. Shouldn't we select NO_UART_ON_SUPERIO?
selecting that in Kconfig doesn't prevent CONSOLE_SERIAL from being available and selected by default, since it's using the SoC UART
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40873 )
Change subject: mb/purism/librem_skl: disable serial console by default ......................................................................
Patch Set 1: Code-Review+2
If UART is not even an option. Shouldn't we select NO_UART_ON_SUPERIO?
selecting that in Kconfig doesn't prevent CONSOLE_SERIAL from being available and selected by default, since it's using the SoC UART
ugh, why is the SoC UART enabled by default?
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40873 )
Change subject: mb/purism/librem_skl: disable serial console by default ......................................................................
Patch Set 1: -Code-Review
Wait, why does it select LPSS_UART_FOR_CONSOLE?
Hello build bot (Jenkins), Nico Huber, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40873
to look at the new patch set (#2).
Change subject: mb/purism/librem_skl: disable serial console output ......................................................................
mb/purism/librem_skl: disable serial console output
Librem SKL/KBL boards do not have an exposed serial port interface. Set board Kconfig so that a default built image with Tianocore payload is bootable and doesn't hang due to trying to send data over a non-existant serial port.
Test: build/boot librem 13v4 with board defaults + Tianocore
Signed-off-by: Matt DeVillier matt.devillier@puri.sm Change-Id: I4c3f8a3c1726f804957b06b437b399291854a3f5 --- M src/mainboard/purism/librem_skl/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/40873/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40873 )
Change subject: mb/purism/librem_skl: disable serial console output ......................................................................
Patch Set 2: Code-Review+1
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40873 )
Change subject: mb/purism/librem_skl: disable serial console output ......................................................................
Patch Set 2: Code-Review+2
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40873 )
Change subject: mb/purism/librem_skl: disable serial console output ......................................................................
Patch Set 2: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40873 )
Change subject: mb/purism/librem_skl: disable serial console output ......................................................................
Patch Set 2: Code-Review+1
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40873 )
Change subject: mb/purism/librem_skl: disable serial console output ......................................................................
mb/purism/librem_skl: disable serial console output
Librem SKL/KBL boards do not have an exposed serial port interface. Set board Kconfig so that a default built image with Tianocore payload is bootable and doesn't hang due to trying to send data over a non-existant serial port.
Test: build/boot librem 13v4 with board defaults + Tianocore
Signed-off-by: Matt DeVillier matt.devillier@puri.sm Change-Id: I4c3f8a3c1726f804957b06b437b399291854a3f5 Reviewed-on: https://review.coreboot.org/c/coreboot/+/40873 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Michael Niewöhner Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net --- M src/mainboard/purism/librem_skl/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, but someone else must approve Michael Niewöhner: Looks good to me, approved
diff --git a/src/mainboard/purism/librem_skl/Kconfig b/src/mainboard/purism/librem_skl/Kconfig index 11bb08d..7a73823 100644 --- a/src/mainboard/purism/librem_skl/Kconfig +++ b/src/mainboard/purism/librem_skl/Kconfig @@ -3,10 +3,10 @@ select BOARD_ROMSIZE_KB_16384 select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES - select INTEL_LPSS_UART_FOR_CONSOLE select INTEL_GMA_HAVE_VBT select MAINBOARD_HAS_LIBGFXINIT select MAINBOARD_HAS_LPC_TPM + select NO_UART_ON_SUPERIO select SOC_INTEL_COMMON_BLOCK_HDA_VERB select SOC_INTEL_KABYLAKE if BOARD_PURISM_LIBREM13_V4 || BOARD_PURISM_LIBREM15_V4 select SOC_INTEL_SKYLAKE if BOARD_PURISM_LIBREM13_V2 || BOARD_PURISM_LIBREM15_V3
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40873 )
Change subject: mb/purism/librem_skl: disable serial console output ......................................................................
Patch Set 5:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/3199 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/3198 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/3197 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/3196
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Angel Pons (Code Review)
-
Matt DeVillier (Code Review)
-
Michael Niewöhner (Code Review)
-
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)