Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/26781 )
Change subject: [WIP]Documentation: Port graphics initialization from wiki ......................................................................
Patch Set 3: Code-Review+1
(19 comments)
Some small grammatical corrections and other nits.
https://review.coreboot.org/c/coreboot/+/26781/3/Documentation/gfx/graphics_... File Documentation/gfx/graphics_init.md:
https://review.coreboot.org/c/coreboot/+/26781/3/Documentation/gfx/graphics_... PS3, Line 2: to bring up of bringing up
https://review.coreboot.org/c/coreboot/+/26781/3/Documentation/gfx/graphics_... PS3, Line 32: Grahpics Graphics
https://review.coreboot.org/c/coreboot/+/26781/3/Documentation/gfx/graphics_... PS3, Line 34: init initialise/initialize
https://review.coreboot.org/c/coreboot/+/26781/3/Documentation/gfx/graphics_... PS3, Line 36: its their
https://review.coreboot.org/c/coreboot/+/26781/3/Documentation/gfx/graphics_... PS3, Line 36: init initialise/initialize
https://review.coreboot.org/c/coreboot/+/26781/3/Documentation/gfx/graphics_... PS3, Line 42: Grahpics Graphics
https://review.coreboot.org/c/coreboot/+/26781/3/Documentation/gfx/graphics_... PS3, Line 46: to with
https://review.coreboot.org/c/coreboot/+/26781/3/Documentation/gfx/graphics_... PS3, Line 57: integrated cards or mobile cards "integrated or mobile cards"
https://review.coreboot.org/c/coreboot/+/26781/3/Documentation/gfx/graphics_... PS3, Line 61: Grahpics Graphics
https://review.coreboot.org/c/coreboot/+/26781/3/Documentation/gfx/graphics_... PS3, Line 66: to with
https://review.coreboot.org/c/coreboot/+/26781/3/Documentation/gfx/graphics_... PS3, Line 74: Is a driver, which is written in a high level language and open source : implementation to initialize the graphics hardware on a specific platform. : Redistribution is possible as the license grants those rights. It might : implement only a subset of possible resolution, when compared to : [VGA Option ROM], a subset of possible color depth and work only on a subset : of available connectors. Possibly: A driver, written in a high level language as an source implementation to initialize the graphics hardware on a specific platform. Redistribution is possible as the license grants those rights. It might implement only a subset of possible resolutions, when compared to [VGA Option ROM], a subset of possible color depth options and work only on a subset of available connectors.
https://review.coreboot.org/c/coreboot/+/26781/3/Documentation/gfx/graphics_... PS3, Line 86: Grahpics Graphics
https://review.coreboot.org/c/coreboot/+/26781/3/Documentation/gfx/graphics_... PS3, Line 90: to with
https://review.coreboot.org/c/coreboot/+/26781/3/Documentation/gfx/graphics_... PS3, Line 124: are not will not be
https://review.coreboot.org/c/coreboot/+/26781/3/Documentation/gfx/graphics_... PS3, Line 125: those such
https://review.coreboot.org/c/coreboot/+/26781/3/Documentation/gfx/graphics_... PS3, Line 148: Grahpics Graphics
https://review.coreboot.org/c/coreboot/+/26781/3/Documentation/gfx/vga_optio... File Documentation/gfx/vga_option_roms.md:
https://review.coreboot.org/c/coreboot/+/26781/3/Documentation/gfx/vga_optio... PS3, Line 4: For older versions of coreboot check the history of this page. This looks like a remnant of the wiki.
Should it be removed, or should we include a link to the wiki history here?
https://review.coreboot.org/c/coreboot/+/26781/3/Documentation/gfx/vga_optio... PS3, Line 62: good well
https://review.coreboot.org/c/coreboot/+/26781/3/Documentation/index.md File Documentation/index.md:
https://review.coreboot.org/c/coreboot/+/26781/3/Documentation/index.md@16 PS3, Line 16: initialisation initialization? The spelling should simply be consistent with other instances.
-
Benjamin Doron (Code Review)