Attention is currently required from: Michał Żygowski, Angel Pons.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68449 )
Change subject: intelblocks/vtd: Add VT-d block with DMA protection API ......................................................................
Patch Set 8:
(2 comments)
File src/soc/intel/common/block/vtd/vtd.c:
https://review.coreboot.org/c/coreboot/+/68449/comment/46f5d39d_c305d3f4 PS8, Line 30: { : 0x45, 0x16, 0xb6, 0x6f, 0x68, 0xf1, 0xbe, 0x46, : 0x80, 0xec, 0xb5, 0x02, 0x38, 0x5e, 0xe7, 0xe7 : }; was going to comment that i'd recommend using GUID_INIT here, but the GUID_INIT macro isn't used in soc/intel, so that wouldn't be consistent with the rest
https://review.coreboot.org/c/coreboot/+/68449/comment/1ee4c8f1_912ca36e PS8, Line 243: for (; hob->type != HOB_TYPE_END_OF_HOB_LIST; : hob = fsp_next_hob(hob)) { : if (hob->type != HOB_TYPE_RESOURCE_DESCRIPTOR) : continue; : : res = fsp_hob_header_to_resource(hob); fsp_hob_iterator_get_next_resource is helper function for this that avoids open coding the functionality