Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30500 )
Change subject: arch/x86/postcar: Add x86_64 support
......................................................................
Patch Set 24: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/30500/24/src/arch/x86/exit_car.S
File src/arch/x86/exit_car.S:
https://review.coreboot.org/c/coreboot/+/30500/24/src/arch/x86/exit_car.S@75
PS24, Line 75: mov %cr0, %rax
: and $(~(CR0_CD | CR0_NW)), %eax
: mov %rax, %cr0
: #else
: mov %cr0, %eax
: and $(~(CR0_CD | CR0_NW)), %eax
: mov %eax, %cr0
maybe 'call enable_cache' ? Not sure how that works with static inlines.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30500
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1c190627f5f0ed6f82738cb99423892382899d7b
Gerrit-Change-Number: 30500
Gerrit-PatchSet: 24
Gerrit-Owner: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 24 Dec 2019 09:04:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment