Hello Kyösti Mälkki, HAOUAS Elyes, Denis Carikli,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/37713
to review the following change.
Change subject: Revert "crossgcc: Upgrade acpica to version 20191018" ......................................................................
Revert "crossgcc: Upgrade acpica to version 20191018"
This reverts commit 547de69de73629c051e9b5312f6369744ec6ce8f.
Merged out of order, the tree has to be fixed first.
Change-Id: Iacbc9877a8ff2324eba4789d65df8545b8a25413 Signed-off-by: Nico Huber nico.huber@secunet.com --- M util/crossgcc/buildgcc R util/crossgcc/patches/acpica-unix2-20190703_iasl.patch A util/crossgcc/sum/acpica-unix2-20190703.tar.gz.cksum D util/crossgcc/sum/acpica-unix2-20191018.tar.gz.cksum 4 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/37713/1
diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index f1cf6bb..5dac074 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -54,7 +54,7 @@ GCC_AUTOCONF_VERSION=2.69 BINUTILS_VERSION=2.33.1 GDB_VERSION=8.3.1 -IASL_VERSION=20191018 +IASL_VERSION=20190703 PYTHON_VERSION=3.8.0 EXPAT_VERSION=2.2.9 # CLANG version number diff --git a/util/crossgcc/patches/acpica-unix2-20191018_iasl.patch b/util/crossgcc/patches/acpica-unix2-20190703_iasl.patch similarity index 100% rename from util/crossgcc/patches/acpica-unix2-20191018_iasl.patch rename to util/crossgcc/patches/acpica-unix2-20190703_iasl.patch diff --git a/util/crossgcc/sum/acpica-unix2-20190703.tar.gz.cksum b/util/crossgcc/sum/acpica-unix2-20190703.tar.gz.cksum new file mode 100644 index 0000000..9a89796 --- /dev/null +++ b/util/crossgcc/sum/acpica-unix2-20190703.tar.gz.cksum @@ -0,0 +1 @@ +c5594944f933265a53695204a0672d0808e4a580 tarballs/acpica-unix2-20190703.tar.gz diff --git a/util/crossgcc/sum/acpica-unix2-20191018.tar.gz.cksum b/util/crossgcc/sum/acpica-unix2-20191018.tar.gz.cksum deleted file mode 100644 index 3df9d27..0000000 --- a/util/crossgcc/sum/acpica-unix2-20191018.tar.gz.cksum +++ /dev/null @@ -1 +0,0 @@ -792e2ec4dcd78646de8405578d28f7437aacf811 tarballs/acpica-unix2-20191018.tar.gz
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37713 )
Change subject: Revert "crossgcc: Upgrade acpica to version 20191018" ......................................................................
Patch Set 1: Code-Review+2
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37713 )
Change subject: Revert "crossgcc: Upgrade acpica to version 20191018" ......................................................................
Patch Set 1: Code-Review+2
HAOUAS Elyes has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/37713 )
Change subject: Revert "crossgcc: Upgrade acpica to version 20191018" ......................................................................
Removed Code-Review+2 by HAOUAS Elyes ehaouas@noos.fr
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37713 )
Change subject: Revert "crossgcc: Upgrade acpica to version 20191018" ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37713/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37713/1//COMMIT_MSG@11 PS1, Line 11: the tree has to be fixed first. Maybe more information :)
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37713 )
Change subject: Revert "crossgcc: Upgrade acpica to version 20191018" ......................................................................
Patch Set 2: Code-Review+2
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37713 )
Change subject: Revert "crossgcc: Upgrade acpica to version 20191018" ......................................................................
Revert "crossgcc: Upgrade acpica to version 20191018"
This reverts commit 547de69de73629c051e9b5312f6369744ec6ce8f.
Merged out of order before CB:36317. The conflicting use of _ADR and _HID needs to be properly addressed before we can bump the IASL version.
Change-Id: Iacbc9877a8ff2324eba4789d65df8545b8a25413 Signed-off-by: Nico Huber nico.huber@secunet.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37713 Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M util/crossgcc/buildgcc R util/crossgcc/patches/acpica-unix2-20190703_iasl.patch A util/crossgcc/sum/acpica-unix2-20190703.tar.gz.cksum D util/crossgcc/sum/acpica-unix2-20191018.tar.gz.cksum 4 files changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved HAOUAS Elyes: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index f1cf6bb..5dac074 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -54,7 +54,7 @@ GCC_AUTOCONF_VERSION=2.69 BINUTILS_VERSION=2.33.1 GDB_VERSION=8.3.1 -IASL_VERSION=20191018 +IASL_VERSION=20190703 PYTHON_VERSION=3.8.0 EXPAT_VERSION=2.2.9 # CLANG version number diff --git a/util/crossgcc/patches/acpica-unix2-20191018_iasl.patch b/util/crossgcc/patches/acpica-unix2-20190703_iasl.patch similarity index 100% rename from util/crossgcc/patches/acpica-unix2-20191018_iasl.patch rename to util/crossgcc/patches/acpica-unix2-20190703_iasl.patch diff --git a/util/crossgcc/sum/acpica-unix2-20190703.tar.gz.cksum b/util/crossgcc/sum/acpica-unix2-20190703.tar.gz.cksum new file mode 100644 index 0000000..9a89796 --- /dev/null +++ b/util/crossgcc/sum/acpica-unix2-20190703.tar.gz.cksum @@ -0,0 +1 @@ +c5594944f933265a53695204a0672d0808e4a580 tarballs/acpica-unix2-20190703.tar.gz diff --git a/util/crossgcc/sum/acpica-unix2-20191018.tar.gz.cksum b/util/crossgcc/sum/acpica-unix2-20191018.tar.gz.cksum deleted file mode 100644 index 3df9d27..0000000 --- a/util/crossgcc/sum/acpica-unix2-20191018.tar.gz.cksum +++ /dev/null @@ -1 +0,0 @@ -792e2ec4dcd78646de8405578d28f7437aacf811 tarballs/acpica-unix2-20191018.tar.gz
-
HAOUAS Elyes (Code Review) -
Kyösti Mälkki (Code Review)
-
Nico Huber (Code Review)