Change in ...coreboot[master]: payloads/coreinfo: Remove unused variable

[Jacob Garber (Code Review)]

Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32796

Change subject: payloads/coreinfo: Remove unused variable
......................................................................

payloads/coreinfo: Remove unused variable

The 'last' variable is unused, and has been for the entire history of
this file.

Found-by: Clang Static Analyzer
Signed-off-by: Jacob Garber 
Change-Id: Ic86a6d8d2b47585f901f1e48ae88735534c834ba
---
M payloads/coreinfo/pci_module.c
1 file changed, 1 insertion(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/32796/1

diff --git a/payloads/coreinfo/pci_module.c b/payloads/coreinfo/pci_module.c
index ff042af..3060161 100644
--- a/payloads/coreinfo/pci_module.c
+++ b/payloads/coreinfo/pci_module.c
@@ -103,15 +103,10 @@
 static int pci_module_redraw(WINDOW *win)
 {
    unsigned int bus, slot, func;
-	int i, last;
+	int i;

print_module_title(win, "PCI Device List");

-	last = menu_first + MENU_VISIBLE;
-
-	if (last > devices_index)
-		last = devices_index;
-
    for (i = 0; i < MENU_VISIBLE; i++) {
    	int item = menu_first + i;

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32796 )

Change subject: payloads/coreinfo: Remove unused variable
......................................................................

Patch Set 1: Code-Review+1

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32796 )

Change subject: payloads/coreinfo: Remove unused variable
......................................................................

Patch Set 1: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32796 )

Change subject: payloads/coreinfo: Remove unused variable
......................................................................

payloads/coreinfo: Remove unused variable

The 'last' variable is unused, and has been for the entire history of
this file.

Found-by: Clang Static Analyzer
Signed-off-by: Jacob Garber 
Change-Id: Ic86a6d8d2b47585f901f1e48ae88735534c834ba
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32796
Tested-by: build bot (Jenkins) 
Reviewed-by: HAOUAS Elyes 
Reviewed-by: Martin Roth 
---
M payloads/coreinfo/pci_module.c
1 file changed, 1 insertion(+), 6 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Martin Roth: Looks good to me, approved
  HAOUAS Elyes: Looks good to me, but someone else must approve

diff --git a/payloads/coreinfo/pci_module.c b/payloads/coreinfo/pci_module.c
index ff042af..3060161 100644
--- a/payloads/coreinfo/pci_module.c
+++ b/payloads/coreinfo/pci_module.c
@@ -103,15 +103,10 @@
 static int pci_module_redraw(WINDOW *win)
 {
    unsigned int bus, slot, func;
-	int i, last;
+	int i;

print_module_title(win, "PCI Device List");

-	last = menu_first + MENU_VISIBLE;
-
-	if (last > devices_index)
-		last = devices_index;
-
    for (i = 0; i < MENU_VISIBLE; i++) {
    	int item = menu_first + i;