Attention is currently required from: Tim Wawrzynczak, Patrick Rudolph. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56173 )
Change subject: soc/intel/common/irq: Account for single-function devices ......................................................................
Patch Set 1:
(2 comments)
File src/soc/intel/common/block/irq/irq.c:
https://review.coreboot.org/c/coreboot/+/56173/comment/8144d8be_02d0e705 PS1, Line 257: IRQ_NONE Should this be `!= IRQ_NONE` or `== IRQ_PIRQ`? What happens if there are multiple functions but only one of them is routed via PIRQ?
https://review.coreboot.org/c/coreboot/+/56173/comment/02314096_a778be72 PS1, Line 266: /* Single-function devices must use PIRQ_A */ If there are multi-function devices, is there any requirement on ensuring that at least one is routed to PIRQ_A?
-
Furquan Shaikh (Code Review)