Paul Menzel (paulepanter@users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5398
-gerrit
commit fc8dca201c65d30c3786f973d470035e6b29ac74 Author: Paul Menzel paulepanter@users.sourceforge.net Date: Sun Mar 23 00:09:32 2014 +0100
samsung/lumpy/ec.c: Do not include `chromeos/chromeos.h`
When not selecting the Kconfig option CHROMEOS, compilation of the board SAMSUNG Lumpy fails as the included header file uses `chromeos_acpi_t`, which is not known to the compiler when not building with support for Chrome OS.
In file included from src/mainboard/samsung/lumpy/ec.c:21:0: src/vendorcode/google/chromeos/chromeos.h:65:43: error: unknown type name 'chromeos_acpi_t'
Luckily, nothing from the header `chromeos.h` is used in `ec.c`, which was probably the case for the board the file was copied from, so do not include it at all.
Change-Id: I7923717bfc5c84698044008e5f2441206041e0dd Reported-by: Idwer Vollering vidwer@gmail.com Signed-off-by: Paul Menzel paulepanter@users.sourceforge.net --- src/mainboard/samsung/lumpy/ec.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/src/mainboard/samsung/lumpy/ec.c b/src/mainboard/samsung/lumpy/ec.c index 40d8319..2406012 100644 --- a/src/mainboard/samsung/lumpy/ec.c +++ b/src/mainboard/samsung/lumpy/ec.c @@ -18,7 +18,6 @@ */
#include <arch/acpi.h> -#include <vendorcode/google/chromeos/chromeos.h> #include <types.h> #include <console/console.h> #include <ec/smsc/mec1308/ec.h>