Change in coreboot[master]: soc/intel/skylake: Move L1_substates_control to pcie_rp.h - coreboot-gerrit

1 Feb 2021


      Attention is currently required from: Nico Huber.
Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50050 )
Change subject: soc/intel/skylake: Move L1_substates_control to pcie_rp.h
......................................................................
Patch Set 2:
(1 comment)
This change is ready for review.
Patchset:
PS2: 
Should the config name be reverted to match the UPD (PcieRpL1Substates) for consistency with other platforms (applies to pcie_rp_aspm as well) or should other platforms be adjusted?
I recall the discussion on CB:39538 (and then CB:45001), but I think that consistency would be good.
This difference might be why Skylake was omitted from the change before.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/50050
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaafc507624151ec871ffcc0fba6da02b012cd038
Gerrit-Change-Number: 50050
Gerrit-PatchSet: 2
Gerrit-Owner: Benjamin Doron benjamin.doron00@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Comment-Date: Mon, 01 Feb 2021 20:39:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment