Change in ...coreboot[master]: asus/am1i-a: set UART_FOR_CONSOLE to 1 instead of default 0

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

Mike Banon (Code Review)

25 Jun 2019 25 Jun '19

9:26 a.m.

Mike Banon has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33776

Change subject: asus/am1i-a: set UART_FOR_CONSOLE to 1 instead of default 0 ......................................................................

asus/am1i-a: set UART_FOR_CONSOLE to 1 instead of default 0

It has been observed by me and Elisenda Cuadros / Gergely Kiss [1] that the boot process of this board is super slow when UART 0 is being used - even if nothing is connected to this port. Instead, use UART 1 by default (this board has two COM ports).

[1] https://mail.coreboot.org/pipermail/coreboot/2018-February/086132.html

Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I42a35d7ac1899a0ac903302f43168dc04701634a --- M src/mainboard/asus/am1i-a/Kconfig 1 file changed, 4 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/33776/1

diff --git a/src/mainboard/asus/am1i-a/Kconfig b/src/mainboard/asus/am1i-a/Kconfig index d50edbe..f692523 100644 --- a/src/mainboard/asus/am1i-a/Kconfig +++ b/src/mainboard/asus/am1i-a/Kconfig @@ -54,4 +54,8 @@ bool default n

+config UART_FOR_CONSOLE + int + default 1 + endif # BOARD_ASUS_AM1I_A

Attachments:

attachment.htm (text/html — 2.6 KB)

Show replies by date

Arthur Heymans (Code Review)

25 Jun 25 Jun

11:08 a.m.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33776 )

Change subject: asus/am1i-a: set UART_FOR_CONSOLE to 1 instead of default 0 ......................................................................

Patch Set 1: Code-Review+1

For some reason the code sets up SP2 instead of SP1, so super slow serial as a result of very high default divider is expected.

Another option is to have the romstage set up SP1 (or both)?

src/mainboard/asus/am1i-a/romstage.c -#define SERIAL_DEV PNP_DEV(0x2e, IT8623E_SP2) +#define SERIAL_DEV PNP_DEV(0x2e, IT8623E_SP1)

-- To view, visit https://review.coreboot.org/c/coreboot/+/33776 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I42a35d7ac1899a0ac903302f43168dc04701634a Gerrit-Change-Number: 33776 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 25 Jun 2019 09:08:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

11:17 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33776 )

Change subject: asus/am1i-a: set UART_FOR_CONSOLE to 1 instead of default 0 ......................................................................

Patch Set 1:

(1 comment)

...

Patch Set 1: Code-Review+1

For some reason the code sets up SP2 instead of SP1, so super slow serial as a result of very high default divider is expected.

Another option is to have the romstage set up SP1 (or both)?

src/mainboard/asus/am1i-a/romstage.c -#define SERIAL_DEV PNP_DEV(0x2e, IT8623E_SP2) +#define SERIAL_DEV PNP_DEV(0x2e, IT8623E_SP1)

I would prefer the bug to be fixed. What about making sure the correct UART is initialized according to UART_FOR_CONSOLE?

https://review.coreboot.org/#/c/33776/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/33776/1//COMMIT_MSG@12 PS1, Line 12: (this board has two COM ports). Very well, but which one is UART 0 and which one is UART 1? Where should one expect the logs to come out of?

-- To view, visit https://review.coreboot.org/c/coreboot/+/33776 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I42a35d7ac1899a0ac903302f43168dc04701634a Gerrit-Change-Number: 33776 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-Comment-Date: Tue, 25 Jun 2019 09:17:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Kyösti Mälkki (Code Review)

1:42 p.m.

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33776 )

Change subject: asus/am1i-a: set UART_FOR_CONSOLE to 1 instead of default 0 ......................................................................

Patch Set 1: Code-Review-1

Fix PNP setup as suggested above instead.

-- To view, visit https://review.coreboot.org/c/coreboot/+/33776 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I42a35d7ac1899a0ac903302f43168dc04701634a Gerrit-Change-Number: 33776 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-Comment-Date: Tue, 25 Jun 2019 11:42:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

1:47 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33776 )

Change subject: asus/am1i-a: set UART_FOR_CONSOLE to 1 instead of default 0 ......................................................................

Patch Set 1: Code-Review-1

-- To view, visit https://review.coreboot.org/c/coreboot/+/33776 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I42a35d7ac1899a0ac903302f43168dc04701634a Gerrit-Change-Number: 33776 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 25 Jun 2019 11:47:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Mike Banon (Code Review)

26 Jun 26 Jun

7:25 a.m.

Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33776 )

Change subject: asus/am1i-a: set UART_FOR_CONSOLE to 1 instead of default 0 ......................................................................

Patch Set 1:

(1 comment)

...

Patch Set 1:

(1 comment)

...
Patch Set 1: Code-Review+1

For some reason the code sets up SP2 instead of SP1, so super slow serial as a result of very high default divider is expected.

Another option is to have the romstage set up SP1 (or both)?

src/mainboard/asus/am1i-a/romstage.c -#define SERIAL_DEV PNP_DEV(0x2e, IT8623E_SP2) +#define SERIAL_DEV PNP_DEV(0x2e, IT8623E_SP1)

I would prefer the bug to be fixed. What about making sure the correct UART is initialized according to UART_FOR_CONSOLE?

I'll try to set up both SP1 and SP2 - so that, if someone switches this setting to another port, he wouldn't encounter this problem.

https://review.coreboot.org/#/c/33776/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/33776/1//COMMIT_MSG@12 PS1, Line 12: (this board has two COM ports).

...

Very well, but which one is UART 0 and which one is UART 1? Where should one expect the logs to come […]

UART 0 = COM 1 (9 pins on-board connector), UART 1 = COM 2 (serial port connector)

-- To view, visit https://review.coreboot.org/c/coreboot/+/33776 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I42a35d7ac1899a0ac903302f43168dc04701634a Gerrit-Change-Number: 33776 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 26 Jun 2019 05:25:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Mike Banon (Code Review)

8:47 a.m.

Mike Banon has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/33776 )

Change subject: asus/am1i-a: set UART_FOR_CONSOLE to 1 instead of default 0 ......................................................................

Abandoned

Please check CB:33796 .

-- To view, visit https://review.coreboot.org/c/coreboot/+/33776 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I42a35d7ac1899a0ac903302f43168dc04701634a Gerrit-Change-Number: 33776 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: abandon

1915

days inactive

1916

days old

coreboot-gerrit@coreboot.org

6 comments

4 participants

tags (0)

participants (4)

Angel Pons (Code Review)
Arthur Heymans (Code Review)
Kyösti Mälkki (Code Review)
Mike Banon (Code Review)