Change in coreboot[master]: cpu/x86/mp_init: Fix false error message on parking APs twice
Attention is currently required from: Nico Huber, Johnny Lin, Stefan Reinauer, Angel Pons. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55071 )
Change subject: cpu/x86/mp_init: Fix false error message on parking APs twice ......................................................................
Patch Set 2:
(1 comment)
File src/cpu/x86/mp_init.c:
https://review.coreboot.org/c/coreboot/+/55071/comment/c2769a12_31a63a12 PS2, Line 1056: printk(BIOS_DEBUG, "%s: CPUs already parked\n", __func__);
We know they had been, but what if they aren't anymore?
What do you mean? There is no code in coreboot to wake APs twice to get them in a ap_wait_for_instruction() state.
Maybe this code will appear in the future, or maybe a blob wakes up the APs again.
That's very specific speculation: the blob AP code would have to call into coreboot code again for this code to be meaningful (romstage AMD AGESA does this, but that's without memory coherency cause no memory ready, so it's not handled by mp init code). It would be a horrible thing to integrate anyway, so let's hope that no silicon vendor ever designs a ramstage blob that way...
-
Arthur Heymans (Code Review)