Change in coreboot[master]: soc/intel/common/pch/lockdown: Lock at end of BS_POST_DEVICE

[Patrick Rudolph (Code Review)]

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39967 )

Change subject: soc/intel/common/pch/lockdown: Lock at end of BS_POST_DEVICE
......................................................................

soc/intel/common/pch/lockdown: Lock at end of BS_POST_DEVICE

There's no need to lock it early. Lock it after device initialization
was finished.

Change-Id: I76cca20bc8dc2a7bdc5f16525919f7ef081df798
Signed-off-by: Patrick Rudolph 
---
M src/soc/intel/common/pch/lockdown/lockdown.c
1 file changed, 1 insertion(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/39967/1

diff --git a/src/soc/intel/common/pch/lockdown/lockdown.c b/src/soc/intel/common/pch/lockdown/lockdown.c
index de45643..684dcee 100644
--- a/src/soc/intel/common/pch/lockdown/lockdown.c
+++ b/src/soc/intel/common/pch/lockdown/lockdown.c
@@ -100,5 +100,4 @@
    soc_lockdown_config(chipset_lockdown);
 }

-BOOT_STATE_INIT_ENTRY(BS_DEV_RESOURCES, BS_ON_EXIT, platform_lockdown_config,
-				NULL);
+BOOT_STATE_INIT_ENTRY(BS_POST_DEVICE, BS_ON_EXIT, platform_lockdown_config, NULL);

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39967 )

Change subject: soc/intel/common/pch/lockdown: Lock at end of BS_POST_DEVICE
......................................................................

Patch Set 2:

I think this was done to not allow option roms to run while settings were unlocked.

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39967 )

Change subject: soc/intel/common/pch/lockdown: Lock at end of BS_POST_DEVICE
......................................................................

Patch Set 2:
> Patch Set 2:
>
> I think this was done to not allow option roms to run while settings were unlocked.

Yes Aaron is right,as per recommendation, before 3rd  party opromm, we need to lock down few chipset registers

is there any problem for pushing it out?

[Patrick Rudolph (Code Review)]

Patrick Rudolph has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/39967 )

Change subject: soc/intel/common/pch/lockdown: Lock at end of BS_POST_DEVICE
......................................................................

Abandoned

Reworked the previous patches instead