Vijay P Hiremath has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37870 )
Change subject: soc/intel/tigerlake: Add code for early tcss ......................................................................
Patch Set 26:
(3 comments)
https://review.coreboot.org/c/coreboot/+/37870/26/src/soc/intel/tigerlake/ea... File src/soc/intel/tigerlake/early_tcss.c:
https://review.coreboot.org/c/coreboot/+/37870/26/src/soc/intel/tigerlake/ea... PS26, Line 29: int req_size; cmd.ipc_cmd.len = directly assign macro and can remove this variable
https://review.coreboot.org/c/coreboot/+/37870/26/src/soc/intel/tigerlake/ea... PS26, Line 32: cmd.ipc_cmd.subcmd = 0; these are not needed (all 3 commands), already initialized
https://review.coreboot.org/c/coreboot/+/37870/26/src/soc/intel/tigerlake/ea... PS26, Line 86: tcss_req[1] |= (1 << 4); ?
-
Vijay P Hiremath (Code Review)