build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28606 )
Change subject: WIP: Port libpayload to riscv ......................................................................
Patch Set 1:
(14 comments)
https://review.coreboot.org/#/c/28606/1/payloads/external/LinuxBoot/Makefile File payloads/external/LinuxBoot/Makefile:
https://review.coreboot.org/#/c/28606/1/payloads/external/LinuxBoot/Makefile... PS1, Line 78: echo "BEFOR DEF" 'BEFOR' may be misspelled - perhaps 'BEFORE'?
https://review.coreboot.org/#/c/28606/1/payloads/libpayload/arch/riscv/coreb... File payloads/libpayload/arch/riscv/coreboot.c:
https://review.coreboot.org/#/c/28606/1/payloads/libpayload/arch/riscv/coreb... PS1, Line 42: switch(rec->tag) { space required before the open parenthesis '('
https://review.coreboot.org/#/c/28606/1/payloads/libpayload/include/riscv/ar... File payloads/libpayload/include/riscv/arch/asm.h:
https://review.coreboot.org/#/c/28606/1/payloads/libpayload/include/riscv/ar... PS1, Line 14: #define ALIGN .align 2 Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/#/c/28606/1/payloads/libpayload/include/riscv/ar... PS1, Line 16: #define ENDPROC(name) \ Macros with multiple statements should be enclosed in a do - while loop
https://review.coreboot.org/#/c/28606/1/payloads/libpayload/include/riscv/ar... PS1, Line 17: .type name, %function; \ need consistent spacing around '%' (ctx:WxV)
https://review.coreboot.org/#/c/28606/1/payloads/libpayload/include/riscv/ar... PS1, Line 20: #define ENTRY(name) \ Macros with multiple statements should be enclosed in a do - while loop
https://review.coreboot.org/#/c/28606/1/payloads/libpayload/include/riscv/ar... PS1, Line 21: .section .text.name, "ax", %progbits; \ need consistent spacing around '%' (ctx:WxV)
https://review.coreboot.org/#/c/28606/1/payloads/libpayload/include/riscv/ar... PS1, Line 24: name: labels should not be indented
https://review.coreboot.org/#/c/28606/1/payloads/libpayload/include/riscv/ar... PS1, Line 26: #define END(name) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/#/c/28606/1/payloads/libpayload/include/riscv/ar... PS1, Line 27: .size name, .-name space required before that '-' (ctx:VxV)
https://review.coreboot.org/#/c/28606/1/payloads/libpayload/include/riscv/ar... File payloads/libpayload/include/riscv/arch/barrier.h:
https://review.coreboot.org/#/c/28606/1/payloads/libpayload/include/riscv/ar... PS1, Line 57: #define mb() memory barrier without comment
https://review.coreboot.org/#/c/28606/1/payloads/libpayload/include/riscv/ar... PS1, Line 58: #define rmb() memory barrier without comment
https://review.coreboot.org/#/c/28606/1/payloads/libpayload/include/riscv/ar... PS1, Line 59: #define wmb() memory barrier without comment
https://review.coreboot.org/#/c/28606/1/payloads/libpayload/include/riscv/ar... File payloads/libpayload/include/riscv/arch/cache.h:
https://review.coreboot.org/#/c/28606/1/payloads/libpayload/include/riscv/ar... PS1, Line 81: } void function return statements are not generally useful
-
build bot (Jenkins) (Code Review)