Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29563 )
Change subject: security/tpm: Fix TCPA log feature ......................................................................
Patch Set 61: Code-Review+1
(5 comments)
https://review.coreboot.org/#/c/29563/61/src/security/tpm/tspi.h File src/security/tpm/tspi.h:
https://review.coreboot.org/#/c/29563/61/src/security/tpm/tspi.h@29 PS61, Line 29: * not needed
https://review.coreboot.org/#/c/29563/61/src/security/tpm/tspi.h@30 PS61, Line 30: ram RAM?
https://review.coreboot.org/#/c/29563/61/src/security/tpm/tspi.h@56 PS61, Line 56: set's sets
https://review.coreboot.org/#/c/29563/61/src/security/tpm/tspi/log.c File src/security/tpm/tspi/log.c:
https://review.coreboot.org/#/c/29563/61/src/security/tpm/tspi/log.c@109 PS61, Line 109: or digest type You only check for name here, so maybe this will be missleading someday?
https://review.coreboot.org/#/c/29563/61/src/security/tpm/tspi/log.c@145 PS61, Line 145: ram RAM?
-
Werner Zeh (Code Review)