Marc Jones has posted comments on this change. ( https://review.coreboot.org/19723 )
Change subject: soc/amd/stoneyridge: Add CPU files ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/19723/3/src/northbridge/amd/pi/Kconfig File src/northbridge/amd/pi/Kconfig:
Line 19: default y if SOC_AMD_PI
Agreed - If we're moving things to SOC, why would we still need pieces in s
yes, the northbridge is the next patch and this was needed to check the build and code worked moving the CPU code.
https://review.coreboot.org/#/c/19723/3/src/soc/amd/common/Kconfig File src/soc/amd/common/Kconfig:
Line 13
But that doesn't really fix the problem entirely. Someone still has to incl
So is there a solution already figured out or we should be doing something completely different here?
-
Marc Jones (Code Review)