build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67342 )
Change subject: drivers/smbus: SC16IS750 I2C to UART converter chip initialization ......................................................................
Patch Set 1:
(3 comments)
File src/drivers/smbus/sc16is750_init.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158062): https://review.coreboot.org/c/coreboot/+/67342/comment/63ade1b7_9289f31a PS1, Line 7: do_smbus_write_byte(CONFIG_FIXED_SMBUS_IO_BASE, \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158062): https://review.coreboot.org/c/coreboot/+/67342/comment/2b3cf374_9f0b81b9 PS1, Line 21: sc16is750_write_byte(REG_LCR << 3, 0b10000011); Avoid gcc v4.3+ binary constant extension: <0b10000011>
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158062): https://review.coreboot.org/c/coreboot/+/67342/comment/fd64fd40_4ac5e1d2 PS1, Line 27: sc16is750_write_byte(REG_LCR << 3, 0b00000011); Avoid gcc v4.3+ binary constant extension: <0b00000011>