Attention is currently required from: Raul Rangel, Jason Nien, Isaac Lee, Tim Wawrzynczak, Jon Murphy, Jason Nein, Martin Roth, Tim Van Patten, Eric Peers, Moises Garcia, Karthikeyan Ramasubramanian.
EricKY Cheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68076 )
Change subject: mb/google/skyrim/var/winterhold: Enable DPTC support for Winterhold
......................................................................
Patch Set 3: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68076/comment/74a79f16_1f6172e1
PS1, Line 8: for Winterhold
nit: Unless someone else objects, this can be removed since the file name prefix already indicates t […]
Done
https://review.coreboot.org/c/coreboot/+/68076/comment/366e0007_dd026248
PS1, Line 13: TEST=emerge-skyrim coreboot
Are you booting these devices with these changes also, to ensure the CLs don't break anything?
Hi Tim, I have no idea on how to ensure the CLs don't break anything
File src/mainboard/google/skyrim/Kconfig:
https://review.coreboot.org/c/coreboot/+/68076/comment/030c6402_92971ad0
PS1, Line 39: select SOC_AMD_COMMON_BLOCK_ACPI_DPTC if !BOARD_GOOGLE_MORTHAL
As Karthik pointed out in another CL, this can be moved to `Kconfig. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68076
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I97c2d3ee29687cd8a9c459e90a45cef05ac4436b
Gerrit-Change-Number: 68076
Gerrit-PatchSet: 3
Gerrit-Owner: EricKY Cheng
ericky_cheng@compal.corp-partner.google.com
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: EricKY Cheng
ericky_cheng@compal.corp-partner.google.com
Gerrit-Reviewer: Isaac Lee
isaaclee@google.com
Gerrit-Reviewer: Jason Nein
finaljason@gmail.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Moises Garcia
moisesgarcia@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Isaac Lee
isaaclee@google.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Jason Nein
finaljason@gmail.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Attention: Eric Peers
epeers@google.com
Gerrit-Attention: Moises Garcia
moisesgarcia@google.com
Gerrit-Attention: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Comment-Date: Tue, 04 Oct 2022 10:30:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Tim Van Patten
timvp@google.com
Gerrit-MessageType: comment