Attention is currently required from: Hung-Te Lin, Xi Chen, Rex-BC Chen, Yidi Lin.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67359 )
Change subject: soc/mediatek: a common implementation to register BL31 reset
......................................................................
Patch Set 5:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/67359/comment/14d00228_2552b6ee
PS4, Line 10: abstract
extract
https://review.coreboot.org/c/coreboot/+/67359/comment/2f71a994_9859a84f
PS4, Line 10: platform
platforms
File src/soc/mediatek/common/bl31.c:
https://review.coreboot.org/c/coreboot/+/67359/comment/8ce9b2c0_05d0db95
PS4, Line 10: int gpio_polarity
How about `bool active_high`? The `ACTIVE_LOW` and `ACTIVE_HIGH` constants are defined for coreboot tables.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67359
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I297ea2e18a6d7e92236cf415844b166523616bdf
Gerrit-Change-Number: 67359
Gerrit-PatchSet: 5
Gerrit-Owner: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Xi Chen
xixi.chen@mediatek.com
Gerrit-Attention: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Comment-Date: Tue, 06 Sep 2022 07:38:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment