Attention is currently required from: Furquan Shaikh, Sugnan Prabhu S, EricR Lai.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56459 )
Change subject: acpigen: Add ability to auto-generate _DSM Function 0
......................................................................
Patch Set 5:
(1 comment)
File src/acpi/acpigen.c:
https://review.coreboot.org/c/coreboot/+/56459/comment/a58014a5_a5ed5dc2
PS5, Line 1657:
: for (size_t i = 1; i < id->count; i++) {
: if (id->callbacks[i]) {
: const size_t buffer_idx = i / (sizeof(uint8_t) * BITS_PER_BYTE);
: const size_t bit_idx = i % (sizeof(uint8_t) * BITS_PER_BYTE);
:
: set = true;
: buffer[buffer_idx] |= BIT(bit_idx);
: }
: }
Hi Tim, […]
Thanks for testing Sugnan! I have fixed the, see the next patchset.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56459
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id9be050442485b42202cf91649aa94e56f35032a
Gerrit-Change-Number: 56459
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-CC: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Tue, 17 Aug 2021 19:37:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-MessageType: comment