Attention is currently required from: V Sowmya, Maulik V Vaghela, Paul Menzel, Tim Wawrzynczak, Subrata Banik, Sridhar Siricilla, Vinay Kumar, Balaji Manigandan, Kane Chen, Srinidhi N Kaushik, Patrick Rudolph.
Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56330 )
Change subject: soc/intel/alderlake: Enable Irms UPD for ADL
......................................................................
Patch Set 12:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56330/comment/a960d603_c59a2792
PS10, Line 9: will set
Present tense: sets
Done
https://review.coreboot.org/c/coreboot/+/56330/comment/77c69797_9796f65c
PS10, Line 9: This change will set Irms config in FSP.
: It will result VR TDC Input current to be
: treated as it is root mean square.
Please re-flow for 75 characters per line.
Done
File src/soc/intel/alderlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/56330/comment/790de896_ac4a8e06
PS10, Line 617: 0x01
Why not just 1?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56330
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ice5c775ef9560503109957a1ed994af1d287aafc
Gerrit-Change-Number: 56330
Gerrit-PatchSet: 12
Gerrit-Owner: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Vinay Kumar
vinay.kumar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: V Sowmya
v.sowmya@intel.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Vinay Kumar
vinay.kumar@intel.com
Gerrit-Attention: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Attention: Kane Chen
kane.chen@intel.com
Gerrit-Attention: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 02 Sep 2021 07:14:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment