Attention is currently required from: Hung-Te Lin, Vince Liu, Wentao Qin, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Vince Liu. ( https://review.coreboot.org/c/coreboot/+/87359?usp=email )
Change subject: mb/google/skywalker: Implement sku_id()
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/mainboard/google/skywalker/boardid.c:
https://review.coreboot.org/c/coreboot/+/87359/comment/932b508d_74e2381f?usp... :
PS1, Line 17: cached_sku_code == CROS_SKU_UNPROVISIONED) {
align
--
To view, visit
https://review.coreboot.org/c/coreboot/+/87359?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6f1343f127537f97bfa4e1f2cfef7db5d46fab67
Gerrit-Change-Number: 87359
Gerrit-PatchSet: 1
Gerrit-Owner: Vince Liu
vince-wl.liu@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Wentao Qin
qinwentao@huaqin.corp-partner.google.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Vince Liu
vince-wl.liu@mediatek.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Attention: Wentao Qin
qinwentao@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Mon, 21 Apr 2025 08:02:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes