Paul Fagerburg has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38902 )
Change subject: volteer: allow empty SPD_SOURCES ......................................................................
volteer: allow empty SPD_SOURCES
Some Volteer variants might not use SPD files. Allow SPD_SOURCES in spd/Makefile.inc to be empty.
BUG=None BRANCH=None TEST=Build coreboot and see that it builds without error
Signed-off-by: Paul Fagerburg pfagerburg@google.com Change-Id: I5a8231b999e16503867d3c8df571b11fa0c1f6a6 --- M src/mainboard/google/volteer/spd/Makefile.inc 1 file changed, 3 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/38902/1
diff --git a/src/mainboard/google/volteer/spd/Makefile.inc b/src/mainboard/google/volteer/spd/Makefile.inc index c4b9e99..9f0106b 100644 --- a/src/mainboard/google/volteer/spd/Makefile.inc +++ b/src/mainboard/google/volteer/spd/Makefile.inc @@ -6,13 +6,10 @@ ## SPDX-License-Identifier: GPL-2.0-or-later ##
+ifneq ($(SPD_SOURCES),) SPD_BIN = $(obj)/spd.bin
-ifeq ($(SPD_SOURCES),) - SPD_DEPS := $(error SPD_SOURCES is not set. Variant must provide this) -else - SPD_DEPS := $(foreach f, $(SPD_SOURCES), src/mainboard/$(MAINBOARDDIR)/spd/$(f).spd.hex) -endif +SPD_DEPS := $(foreach f, $(SPD_SOURCES), src/mainboard/$(MAINBOARDDIR)/spd/$(f).spd.hex)
# Include spd ROM data $(SPD_BIN): $(SPD_DEPS) @@ -25,3 +22,4 @@ cbfs-files-y += spd.bin spd.bin-file := $(SPD_BIN) spd.bin-type := spd +endif
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38902 )
Change subject: volteer: allow empty SPD_SOURCES ......................................................................
Patch Set 1:
Adding this to public coreboot per Furquan's comment on crrev.com/i/2556694
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38902 )
Change subject: volteer: allow empty SPD_SOURCES ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38902 )
Change subject: volteer: allow empty SPD_SOURCES ......................................................................
volteer: allow empty SPD_SOURCES
Some Volteer variants might not use SPD files. Allow SPD_SOURCES in spd/Makefile.inc to be empty.
BUG=None BRANCH=None TEST=Build coreboot and see that it builds without error
Signed-off-by: Paul Fagerburg pfagerburg@google.com Change-Id: I5a8231b999e16503867d3c8df571b11fa0c1f6a6 Reviewed-on: https://review.coreboot.org/c/coreboot/+/38902 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/volteer/spd/Makefile.inc 1 file changed, 3 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/volteer/spd/Makefile.inc b/src/mainboard/google/volteer/spd/Makefile.inc index c4b9e99..9f0106b 100644 --- a/src/mainboard/google/volteer/spd/Makefile.inc +++ b/src/mainboard/google/volteer/spd/Makefile.inc @@ -6,13 +6,10 @@ ## SPDX-License-Identifier: GPL-2.0-or-later ##
+ifneq ($(SPD_SOURCES),) SPD_BIN = $(obj)/spd.bin
-ifeq ($(SPD_SOURCES),) - SPD_DEPS := $(error SPD_SOURCES is not set. Variant must provide this) -else - SPD_DEPS := $(foreach f, $(SPD_SOURCES), src/mainboard/$(MAINBOARDDIR)/spd/$(f).spd.hex) -endif +SPD_DEPS := $(foreach f, $(SPD_SOURCES), src/mainboard/$(MAINBOARDDIR)/spd/$(f).spd.hex)
# Include spd ROM data $(SPD_BIN): $(SPD_DEPS) @@ -25,3 +22,4 @@ cbfs-files-y += spd.bin spd.bin-file := $(SPD_BIN) spd.bin-type := spd +endif
-
Furquan Shaikh (Code Review) -
Patrick Georgi (Code Review)
-
Paul Fagerburg (Code Review)