Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30967
Change subject: util/autoport: Correct DSDT header ......................................................................
util/autoport: Correct DSDT header
A previous change emoved model_206ax code to a common place, but forgot to update autoport. Correct this so resulting autoport errors less.
Change-Id: I51b7e9c5d226f591596c33d6a3cb326a34420493 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M util/autoport/sandybridge.go 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/30967/1
diff --git a/util/autoport/sandybridge.go b/util/autoport/sandybridge.go index cf2b859..4f08ad9 100644 --- a/util/autoport/sandybridge.go +++ b/util/autoport/sandybridge.go @@ -122,7 +122,7 @@ KconfigInt["MAX_CPUS"] = 8
DSDTIncludes = append(DSDTIncludes, DSDTInclude{ - File: "cpu/intel/model_206ax/acpi/cpu.asl", + File: "cpu/intel/common/acpi/cpu.asl", })
DSDTPCI0Includes = append(DSDTPCI0Includes, DSDTInclude{
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/30967
to look at the new patch set (#2).
Change subject: util/autoport: Correct DSDT include ......................................................................
util/autoport: Correct DSDT include
A previous change emoved model_206ax code to a common place, but forgot to update autoport. Correct this so resulting autoport errors less.
Change-Id: I51b7e9c5d226f591596c33d6a3cb326a34420493 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M util/autoport/sandybridge.go 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/30967/2
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/30967
to look at the new patch set (#3).
Change subject: util/autoport: Correct DSDT include ......................................................................
util/autoport: Correct DSDT include
A previous change moved model_206ax code to a common place, but forgot to update autoport. Correct this so resulting autoport errors less.
Change-Id: I51b7e9c5d226f591596c33d6a3cb326a34420493 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M util/autoport/sandybridge.go 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/30967/3
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/30967
to look at the new patch set (#4).
Change subject: util/autoport: Correct DSDT header ......................................................................
util/autoport: Correct DSDT header
A previous change emoved model_206ax code to a common place, but forgot to update autoport. Correct this so resulting autoport errors less.
Change-Id: I51b7e9c5d226f591596c33d6a3cb326a34420493 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M util/autoport/sandybridge.go 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/30967/4
Tristan Corrick has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30967 )
Change subject: util/autoport: Correct DSDT header ......................................................................
Patch Set 4: Code-Review+1
(4 comments)
Looks good, just a few nits with the commit message.
https://review.coreboot.org/#/c/30967/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/30967/4//COMMIT_MSG@7 PS4, Line 7: header Do you mean "include statement"?
https://review.coreboot.org/#/c/30967/4//COMMIT_MSG@9 PS4, Line 9: change Please give the commit hash and summary.
https://review.coreboot.org/#/c/30967/4//COMMIT_MSG@9 PS4, Line 9: emoved Typo: "moved".
https://review.coreboot.org/#/c/30967/4//COMMIT_MSG@10 PS4, Line 10: Correct this so resulting autoport errors less. This sentence doesn't make sense. Perhaps say that it fixes build errors in the autoport output, or omit it altogether.
Hello Tristan Corrick, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/30967
to look at the new patch set (#5).
Change subject: util/autoport: Correct DSDT include statement ......................................................................
util/autoport: Correct DSDT include statement
With commit aaced4a932dc68268cebace63df079673960c17b (cpu/intel/common: Use a common acpi/cpu.asl file) moved model_206ax code to a common place, but autoport was not updated accordingly.
Change-Id: I51b7e9c5d226f591596c33d6a3cb326a34420493 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M util/autoport/sandybridge.go 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/30967/5
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30967 )
Change subject: util/autoport: Correct DSDT include statement ......................................................................
Patch Set 5:
(4 comments)
https://review.coreboot.org/#/c/30967/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/30967/4//COMMIT_MSG@7 PS4, Line 7: header
Do you mean "include statement"?
Done
https://review.coreboot.org/#/c/30967/4//COMMIT_MSG@9 PS4, Line 9: change
Please give the commit hash and summary.
Done
https://review.coreboot.org/#/c/30967/4//COMMIT_MSG@9 PS4, Line 9: emoved
Typo: "moved".
As you can see, I corrected this on PS3, but overwrote this with PS4 ._. Fixed.
https://review.coreboot.org/#/c/30967/4//COMMIT_MSG@10 PS4, Line 10: Correct this so resulting autoport errors less.
This sentence doesn't make sense. Perhaps say that it fixes build errors […]
Done
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30967 )
Change subject: util/autoport: Correct DSDT include statement ......................................................................
Patch Set 5: Code-Review+1
(2 comments)
https://review.coreboot.org/#/c/30967/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/30967/5//COMMIT_MSG@9 PS5, Line 9: aaced4a932dc68268cebace63df079673960c17b Please use the short hash.
https://review.coreboot.org/#/c/30967/5//COMMIT_MSG@9 PS5, Line 9: With commit aaced4a932dc68268cebace63df079673960c17b (cpu/intel/common: : Use a common acpi/cpu.asl file) moved model_206ax Commit … moves …?
Hello Tristan Corrick, Paul Menzel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/30967
to look at the new patch set (#6).
Change subject: util/autoport: Correct DSDT include statement ......................................................................
util/autoport: Correct DSDT include statement
With commit aaced4a (cpu/intel/common: Use a common acpi/cpu.asl file), some model_206ax code was moved to a common place. However, autoport was not updated accordingly.
Change-Id: I51b7e9c5d226f591596c33d6a3cb326a34420493 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M util/autoport/sandybridge.go 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/30967/6
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30967 )
Change subject: util/autoport: Correct DSDT include statement ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/#/c/30967/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/30967/5//COMMIT_MSG@9 PS5, Line 9: aaced4a932dc68268cebace63df079673960c17b
Please use the short hash.
Done
https://review.coreboot.org/#/c/30967/5//COMMIT_MSG@9 PS5, Line 9: With commit aaced4a932dc68268cebace63df079673960c17b (cpu/intel/common: : Use a common acpi/cpu.asl file) moved model_206ax
Commit … moves …?
Much correctness many Engrish... Done
Tristan Corrick has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30967 )
Change subject: util/autoport: Correct DSDT include statement ......................................................................
Patch Set 6: Code-Review+2
Felix Held has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/30967 )
Change subject: util/autoport: Correct DSDT include statement ......................................................................
util/autoport: Correct DSDT include statement
With commit aaced4a (cpu/intel/common: Use a common acpi/cpu.asl file), some model_206ax code was moved to a common place. However, autoport was not updated accordingly.
Change-Id: I51b7e9c5d226f591596c33d6a3cb326a34420493 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/30967 Reviewed-by: Tristan Corrick tristan@corrick.kiwi Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M util/autoport/sandybridge.go 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Tristan Corrick: Looks good to me, approved
diff --git a/util/autoport/sandybridge.go b/util/autoport/sandybridge.go index cf2b859..4f08ad9 100644 --- a/util/autoport/sandybridge.go +++ b/util/autoport/sandybridge.go @@ -122,7 +122,7 @@ KconfigInt["MAX_CPUS"] = 8
DSDTIncludes = append(DSDTIncludes, DSDTInclude{ - File: "cpu/intel/model_206ax/acpi/cpu.asl", + File: "cpu/intel/common/acpi/cpu.asl", })
DSDTPCI0Includes = append(DSDTPCI0Includes, DSDTInclude{
-
Angel Pons (Code Review) -
Felix Held (Code Review)
-
Paul Menzel (Code Review)
-
Tristan Corrick (Code Review)