Attention is currently required from: Raul Rangel, Martin Roth, Furquan Shaikh, Marshall Dawson, Andrey Petrov, Patrick Rudolph, Felix Held.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51575 )
Change subject: drivers/intel/fsp2_0/Kconfig: select HAVE_DISPLAY_MTRRS
......................................................................
Patch Set 2:
(1 comment)
File src/drivers/intel/fsp2_0/Kconfig:
https://review.coreboot.org/c/coreboot/+/51575/comment/a2dcade9_ceb11413
PS2, Line 6: select HAVE_DISPLAY_MTRRS
no, a depends on isn't the right thing to do here, since the fsp driver itself provides some functionality to print the mtrrs, so we can unhide the option to print the mtrrs with selecting this option in the fsp driver's Kconfig. if some component provides certain functionality that has a kconfig option to show that the is implemented, that component needs to select that option
Um, sorry, I don't follow. `HAVE_DISPLAY_MTRRS` is used to show/hide `DISPLAY_MTRRS`, Where exactly does the FSP driver provide functionality to print the MSRs?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51575
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2894689ce58e7404d9d5a894f3c288bc4016ea19
Gerrit-Change-Number: 51575
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sun, 05 Sep 2021 23:10:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment