Attention is currently required from: Felix Singer, Angel Pons, Patrick Rudolph. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52692 )
Change subject: soc/intel/skylake: Add Kconfig option for LGA1151v2 ......................................................................
Patch Set 10:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52692/comment/15615b64_678fd7e0 PS5, Line 15: mainboard
nit: move to previous line
Gone, but now there's another overlong line...
Commit Message:
https://review.coreboot.org/c/coreboot/+/52692/comment/10d1ad1b_a76fa812 PS10, Line 12: As of the year 2021 it's common for motherboards with Z370, H310C or B365 PCHs, Please reflow the paragraph so it fits in one line (72 chars).
File src/soc/intel/skylake/Kconfig:
https://review.coreboot.org/c/coreboot/+/52692/comment/6c853b52_ada96e96 PS5, Line 21: Intel chipsets with LGA1151v2 socket (e.g., B365, H310C, Z370) support
Hmm, chipsets don't have a socket. How about: […]
Done
https://review.coreboot.org/c/coreboot/+/52692/comment/cf9ecc9d_debf7fbf PS5, Line 256: # SkylakeFsp is FSP 1.1 and therefore incompatible.
Because it's not only about FSP_HEADER_PATH, but also about FSP_FD_PATH
Ack
-
Nico Huber (Code Review)