Attention is currently required from: Frank Wu, Jason Nien, Karthik Ramasubramanian, Martin Roth.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77678?usp=email )
Change subject: mb/google/skyrim/frostflow: Drop GPIO override for camera shutter
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/skyrim/variants/frostflow/gpio.c:
https://review.coreboot.org/c/coreboot/+/77678/comment/5448642e_e0b4c081 :
PS1, Line 10: /* EN_PWR_WWAN_X => CAM_PSW_L */
: PAD_INT(GPIO_8, PULL_NONE, BOTH_EDGES, STATUS_DELIVERY),
The AGPIO8(CAM_PSW_L) is still defined in the latest schematic in frostflow but resistance is not mo […]
marking as resolved since confirmed the GPIO is not connected on the board
--
To view, visit
https://review.coreboot.org/c/coreboot/+/77678?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8a6ea3b886766bdb055b40949c75bec0264eecc5
Gerrit-Change-Number: 77678
Gerrit-PatchSet: 3
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Wed, 15 Nov 2023 15:15:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Frank Wu
frank_wu@compal.corp-partner.google.com
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment