Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39195 )
Change subject: mb/intel/jasperlake_rvp: Add memory config for jslrvp ......................................................................
Patch Set 13:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39195/12/src/mainboard/intel/jasper... File src/mainboard/intel/jasperlake_rvp/variants/baseboard/include/baseboard/variants.h:
https://review.coreboot.org/c/coreboot/+/39195/12/src/mainboard/intel/jasper... PS12, Line 1: uu
needs to be removed..
Done
https://review.coreboot.org/c/coreboot/+/39195/12/src/mainboard/intel/jasper... File src/mainboard/intel/jasperlake_rvp/variants/jslrvp/memory.c:
https://review.coreboot.org/c/coreboot/+/39195/12/src/mainboard/intel/jasper... PS12, Line 117: else
else is not generally useful after a break or return
Done
-
Maulik V Vaghela (Code Review)