Jamie Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35041 )
Change subject: mb/google/hatch: Override DLL values for Kindred ......................................................................
mb/google/hatch: Override DLL values for Kindred
New emmc DLL values for Kindred
BUG=b:136784418 BRANCH=none TEST=Boot to OS 100 times on Kindred proto 1 board.
Change-Id: I52acb445c47fcdb9b60512dd501d810b1ae4dc10 Signed-off-by: Jamie Chen jamie.chen@intel.com --- M src/mainboard/google/hatch/variants/kindred/variant.c 1 file changed, 12 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/35041/1
diff --git a/src/mainboard/google/hatch/variants/kindred/variant.c b/src/mainboard/google/hatch/variants/kindred/variant.c index 6cd017b..619d5fc 100644 --- a/src/mainboard/google/hatch/variants/kindred/variant.c +++ b/src/mainboard/google/hatch/variants/kindred/variant.c @@ -17,6 +17,7 @@ #include <chip.h> #include <soc/pci_devs.h> #include <ec/google/chromeec/ec.h> +#include <intelblocks/early_mmc.h>
void variant_devtree_update(void) { @@ -47,3 +48,14 @@ cfg->satapwroptimize = 0; } } + +int mainboard_get_mmc_dll(struct mmc_dll_params *params) +{ + params->emmc_tx_data_cntl1 = 0x0F10; + params->emmc_tx_data_cntl2 = 0x1C2F2D2D; + params->emmc_rx_cmd_data_cntl1 = 0x1C121936; + params->emmc_rx_cmd_data_cntl2 = 0x1182D; + params->emmc_rx_strobe_cntl = 0x1414; ; + params->emmc_tx_cmd_cntl = 0x0505; + return 0; +}
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35041 )
Change subject: mb/google/hatch: Override DLL values for Kindred ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35041/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kindred/variant.c:
https://review.coreboot.org/c/coreboot/+/35041/1/src/mainboard/google/hatch/... PS1, Line 58: params->emmc_rx_strobe_cntl = 0x1414; ; space prohibited before semicolon
https://review.coreboot.org/c/coreboot/+/35041/1/src/mainboard/google/hatch/... PS1, Line 58: params->emmc_rx_strobe_cntl = 0x1414; ; Statements terminations use 1 semicolon
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35041
to look at the new patch set (#2).
Change subject: mb/google/hatch: Override DLL values for Kindred ......................................................................
mb/google/hatch: Override DLL values for Kindred
New emmc DLL values for Kindred
BUG=b:136784418 BRANCH=none TEST=Boot to OS 100 times on Kindred proto 1 board.
Change-Id: I52acb445c47fcdb9b60512dd501d810b1ae4dc10 Signed-off-by: Jamie Chen jamie.chen@intel.com --- M src/mainboard/google/hatch/variants/kindred/variant.c 1 file changed, 12 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/35041/2
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35041 )
Change subject: mb/google/hatch: Override DLL values for Kindred ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35041/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kindred/variant.c:
https://review.coreboot.org/c/coreboot/+/35041/2/src/mainboard/google/hatch/... PS2, Line 52: mainboard_get_mmc_dll can't we have soc level function and below hardcoded value moved into chip.h configs to be filled from mainboard ?
Hello Subrata Banik, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35041
to look at the new patch set (#3).
Change subject: mb/google/hatch: Override DLL values for Kindred ......................................................................
mb/google/hatch: Override DLL values for Kindred
New emmc DLL values for Kindred
BUG=b:136784418 BRANCH=none TEST=Boot to OS 100 times on Kindred proto 1 board.
Change-Id: I52acb445c47fcdb9b60512dd501d810b1ae4dc10 Signed-off-by: Jamie Chen jamie.chen@intel.com --- M src/mainboard/google/hatch/Kconfig M src/mainboard/google/hatch/variants/kindred/overridetree.cb 2 files changed, 45 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/35041/3
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35041 )
Change subject: mb/google/hatch: Override DLL values for Kindred ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35041/5/src/mainboard/google/hatch/... File src/mainboard/google/hatch/Kconfig:
https://review.coreboot.org/c/coreboot/+/35041/5/src/mainboard/google/hatch/... PS5, Line 125: config SOC_INTEL_COMMON_MMC_OVERRIDE : bool : default y if BOARD_GOOGLE_KINDRED can't we select SOC_INTEL_COMMON_MMC_OVERRIDE from src/mainboard/goggle/hatch/Kconfig.name under config BOARD_GOOGLE_KINDRED ?
May be should check with Furquan?
Hello Subrata Banik, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35041
to look at the new patch set (#6).
Change subject: mb/google/hatch: Override DLL values for Kindred ......................................................................
mb/google/hatch: Override DLL values for Kindred
New emmc DLL values for Kindred
BUG=b:136784418 BRANCH=none TEST=Boot to OS 100 times on Kindred proto 1 board.
Change-Id: I52acb445c47fcdb9b60512dd501d810b1ae4dc10 Signed-off-by: Jamie Chen jamie.chen@intel.com --- M src/mainboard/google/hatch/variants/kindred/overridetree.cb 1 file changed, 45 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/35041/6
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35041 )
Change subject: mb/google/hatch: Override DLL values for Kindred ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35041/5/src/mainboard/google/hatch/... File src/mainboard/google/hatch/Kconfig:
https://review.coreboot.org/c/coreboot/+/35041/5/src/mainboard/google/hatch/... PS5, Line 125: config SOC_INTEL_COMMON_MMC_OVERRIDE : bool : default y if BOARD_GOOGLE_KINDRED
can't we select SOC_INTEL_COMMON_MMC_OVERRIDE from src/mainboard/goggle/hatch/Kconfig. […]
looks like this been moved here https://review.coreboot.org/c/coreboot/+/35094/1
@Furuqan, do you think we can select the same from kconfig.name ?
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35041 )
Change subject: mb/google/hatch: Override DLL values for Kindred ......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35041/5/src/mainboard/google/hatch/... File src/mainboard/google/hatch/Kconfig:
https://review.coreboot.org/c/coreboot/+/35041/5/src/mainboard/google/hatch/... PS5, Line 125: config SOC_INTEL_COMMON_MMC_OVERRIDE : bool : default y if BOARD_GOOGLE_KINDRED
can't we select SOC_INTEL_COMMON_MMC_OVERRIDE from src/mainboard/goggle/hatch/Kconfig. […]
Please see my comment on previous CL in this set about not requiring the config at all.
https://review.coreboot.org/c/coreboot/+/35041/8/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kindred/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/35041/8/src/mainboard/google/hatch/... PS8, Line 53: EDS-Vol2-16.32 Is this for CML? I don't see it in the EDS under this section.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35041 )
Change subject: mb/google/hatch: Override DLL values for Kindred ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35041/5/src/mainboard/google/hatch/... File src/mainboard/google/hatch/Kconfig:
https://review.coreboot.org/c/coreboot/+/35041/5/src/mainboard/google/hatch/... PS5, Line 125: config SOC_INTEL_COMMON_MMC_OVERRIDE : bool : default y if BOARD_GOOGLE_KINDRED
@Furuqan, do you think we can select the same from kconfig.name ?
If we decide to go with the config, then yes, adding it to Kconfig.name should be fine.
Hello Subrata Banik, Kane Chen, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35041
to look at the new patch set (#9).
Change subject: mb/google/hatch: Override DLL values for Kindred ......................................................................
mb/google/hatch: Override DLL values for Kindred
New emmc DLL values for Kindred
BUG=b:136784418 BRANCH=none TEST=Boot to OS 100 times on Kindred proto 1 board.
Change-Id: I52acb445c47fcdb9b60512dd501d810b1ae4dc10 Signed-off-by: Jamie Chen jamie.chen@intel.com --- M src/mainboard/google/hatch/variants/kindred/overridetree.cb 1 file changed, 45 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/35041/9
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35041 )
Change subject: mb/google/hatch: Override DLL values for Kindred ......................................................................
Patch Set 11: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35041 )
Change subject: mb/google/hatch: Override DLL values for Kindred ......................................................................
Patch Set 15:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35041/15//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35041/15//COMMIT_MSG@9 PS15, Line 9: DLL Were did you get those from?
Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35041 )
Change subject: mb/google/hatch: Override DLL values for Kindred ......................................................................
Patch Set 15:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35041/15//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35041/15//COMMIT_MSG@9 PS15, Line 9: DLL
Were did you get those from?
sorry, by internal tool
Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35041 )
Change subject: mb/google/hatch: Override DLL values for Kindred ......................................................................
Patch Set 15:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35041/15//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35041/15//COMMIT_MSG@9 PS15, Line 9: DLL
sorry, by internal tool
Done
https://review.coreboot.org/c/coreboot/+/35041/5/src/mainboard/google/hatch/... File src/mainboard/google/hatch/Kconfig:
https://review.coreboot.org/c/coreboot/+/35041/5/src/mainboard/google/hatch/... PS5, Line 125: config SOC_INTEL_COMMON_MMC_OVERRIDE : bool : default y if BOARD_GOOGLE_KINDRED
@Furuqan, do you think we can select the same from kconfig.name ? […]
Done
https://review.coreboot.org/c/coreboot/+/35041/8/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kindred/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/35041/8/src/mainboard/google/hatch/... PS8, Line 53: EDS-Vol2-16.32
Is this for CML? I don't see it in the EDS under this section.
Done
Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35041 )
Change subject: mb/google/hatch: Override DLL values for Kindred ......................................................................
Patch Set 15:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35041/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kindred/variant.c:
https://review.coreboot.org/c/coreboot/+/35041/2/src/mainboard/google/hatch/... PS2, Line 52: mainboard_get_mmc_dll
can't we have soc level function and below hardcoded value moved into chip. […]
Done
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/35041 )
Change subject: mb/google/hatch: Override DLL values for Kindred ......................................................................
mb/google/hatch: Override DLL values for Kindred
New emmc DLL values for Kindred
BUG=b:136784418 BRANCH=none TEST=Boot to OS 100 times on Kindred proto 1 board.
Change-Id: I52acb445c47fcdb9b60512dd501d810b1ae4dc10 Signed-off-by: Jamie Chen jamie.chen@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35041 Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/hatch/variants/kindred/overridetree.cb 1 file changed, 45 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/variants/kindred/overridetree.cb b/src/mainboard/google/hatch/variants/kindred/overridetree.cb index a4ca176..38d7e48 100644 --- a/src/mainboard/google/hatch/variants/kindred/overridetree.cb +++ b/src/mainboard/google/hatch/variants/kindred/overridetree.cb @@ -49,6 +49,51 @@ # Enable eMMC HS400 register "ScsEmmcHs400Enabled" = "1"
+ # EMMC Tx CMD Delay + # Refer to EDS-Vol2-14.3.7. + # [14:8] steps of delay for DDR mode, each 125ps, range: 0 - 39. + # [6:0] steps of delay for SDR mode, each 125ps, range: 0 - 39. + register "common_soc_config.emmc_dll.emmc_tx_cmd_cntl" = "0x505" + + # EMMC TX DATA Delay 1 + # Refer to EDS-Vol2-14.3.8. + # [14:8] steps of delay for HS400, each 125ps, range: 0 - 78. + # [6:0] steps of delay for SDR104/HS200, each 125ps, range: 0 - 79. + register "common_soc_config.emmc_dll.emmc_tx_data_cntl1" = "0x0F10" + + # EMMC TX DATA Delay 2 + # Refer to EDS-Vol2-14.3.9. + # [30:24] steps of delay for SDR50, each 125ps, range: 0 - 79. + # [22:16] steps of delay for DDR50, each 125ps, range: 0 - 78. + # [14:8] steps of delay for SDR25/HS50, each 125ps, range: 0 -79. + # [6:0] steps of delay for SDR12, each 125ps. Range: 0 - 79. + register "common_soc_config.emmc_dll.emmc_tx_data_cntl2" = "0x1C2F2D2D" + + # EMMC RX CMD/DATA Delay 1 + # Refer to EDS-Vol2-14.3.10. + # [30:24] steps of delay for SDR50, each 125ps, range: 0 - 119. + # [22:16] steps of delay for DDR50, each 125ps, range: 0 - 78. + # [14:8] steps of delay for SDR25/HS50, each 125ps, range: 0 - 119. + # [6:0] steps of delay for SDR12, each 125ps, range: 0 - 119. + register "common_soc_config.emmc_dll.emmc_rx_cmd_data_cntl1" = "0x1C121936" + + # EMMC RX CMD/DATA Delay 2 + # Refer to EDS-Vol2-14.3.12. + # [17:16] stands for Rx Clock before Output Buffer, + # 00: Rx clock after output buffer, + # 01: Rx clock before output buffer, + # 10: Automatic selection based on working mode. + # 11: Reserved + # [14:8] steps of delay for Auto Tuning Mode, each 125ps, range: 0 - 39. + # [6:0] steps of delay for HS200, each 125ps, range: 0 - 79. + register "common_soc_config.emmc_dll.emmc_rx_cmd_data_cntl2" = "0x1182D" + + # EMMC Rx Strobe Delay + # Refer to EDS-Vol2-14.3.11. + # [14:8] Rx Strobe Delay DLL 1(HS400 Mode), each 125ps, range: 0 - 39. + # [6:0] Rx Strobe Delay DLL 2(HS400 Mode), each 125ps, range: 0 - 39. + register "common_soc_config.emmc_dll.emmc_rx_strobe_cntl" = "0x1414" + device domain 0 on device pci 15.0 on chip drivers/i2c/generic
-
build bot (Jenkins) (Code Review) -
Furquan Shaikh (Code Review)
-
Jamie Chen (Code Review)
-
Kane Chen (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)
-
Subrata Banik (Code Review)