Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37038 )
Change subject: ec/google/chromeec: Drop CAR_GLOBAL_MIGRATION support ......................................................................
ec/google/chromeec: Drop CAR_GLOBAL_MIGRATION support
Change-Id: I09bca1897920871a6b29c25dc2bad94a8061da29 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/ec/google/chromeec/ec.c M src/ec/google/chromeec/ec_spi.c 2 files changed, 1 insertion(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/37038/1
diff --git a/src/ec/google/chromeec/ec.c b/src/ec/google/chromeec/ec.c index a992146..5dff162 100644 --- a/src/ec/google/chromeec/ec.c +++ b/src/ec/google/chromeec/ec.c @@ -17,7 +17,6 @@ #include <string.h> #include <cbmem.h> #include <console/console.h> -#include <arch/early_variables.h> #include <assert.h> #include <bootmode.h> #include <bootstate.h> @@ -231,7 +230,7 @@ #define UHEPI_SUPPORTED 1 #define UHEPI_NOT_SUPPORTED 2
- static int uhepi_support CAR_GLOBAL; + static int uhepi_support;
if (!uhepi_support) { uhepi_support = google_chromeec_check_feature diff --git a/src/ec/google/chromeec/ec_spi.c b/src/ec/google/chromeec/ec_spi.c index c47d419..84a605b 100644 --- a/src/ec/google/chromeec/ec_spi.c +++ b/src/ec/google/chromeec/ec_spi.c @@ -20,8 +20,6 @@ #include <spi-generic.h> #include <timer.h>
-/* This is assuming that this driver is not used on x86. If that changes, this - might need to become a CAR_GLOBAL or maybe even more complicated. */ static struct stopwatch cs_cooldown_sw; static const long cs_cooldown_us = 200;
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37038 )
Change subject: ec/google/chromeec: Drop CAR_GLOBAL_MIGRATION support ......................................................................
Patch Set 7: Code-Review+1
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37038 )
Change subject: ec/google/chromeec: Drop CAR_GLOBAL_MIGRATION support ......................................................................
Patch Set 7: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37038 )
Change subject: ec/google/chromeec: Drop CAR_GLOBAL_MIGRATION support ......................................................................
ec/google/chromeec: Drop CAR_GLOBAL_MIGRATION support
Change-Id: I09bca1897920871a6b29c25dc2bad94a8061da29 Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/37038 Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Reviewed-by: Patrick Georgi pgeorgi@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/ec/google/chromeec/ec.c M src/ec/google/chromeec/ec_spi.c 2 files changed, 1 insertion(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved HAOUAS Elyes: Looks good to me, but someone else must approve
diff --git a/src/ec/google/chromeec/ec.c b/src/ec/google/chromeec/ec.c index a992146..5dff162 100644 --- a/src/ec/google/chromeec/ec.c +++ b/src/ec/google/chromeec/ec.c @@ -17,7 +17,6 @@ #include <string.h> #include <cbmem.h> #include <console/console.h> -#include <arch/early_variables.h> #include <assert.h> #include <bootmode.h> #include <bootstate.h> @@ -231,7 +230,7 @@ #define UHEPI_SUPPORTED 1 #define UHEPI_NOT_SUPPORTED 2
- static int uhepi_support CAR_GLOBAL; + static int uhepi_support;
if (!uhepi_support) { uhepi_support = google_chromeec_check_feature diff --git a/src/ec/google/chromeec/ec_spi.c b/src/ec/google/chromeec/ec_spi.c index c47d419..84a605b 100644 --- a/src/ec/google/chromeec/ec_spi.c +++ b/src/ec/google/chromeec/ec_spi.c @@ -20,8 +20,6 @@ #include <spi-generic.h> #include <timer.h>
-/* This is assuming that this driver is not used on x86. If that changes, this - might need to become a CAR_GLOBAL or maybe even more complicated. */ static struct stopwatch cs_cooldown_sw; static const long cs_cooldown_us = 200;
-
Arthur Heymans (Code Review) -
HAOUAS Elyes (Code Review)
-
Patrick Georgi (Code Review)