Attention is currently required from: Wonkyu Kim, Subrata Banik, Tim Wawrzynczak.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63890 )
Change subject: [DO NOT SUBMIT] soc/intel/alderlake: Enable MCHBAR in bootblock
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/alderlake/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/63890/comment/da9f323f_5de6caca
PS1, Line 23: sa_set_pci_bar(soc_fixed_pci_resources, ARRAY_SIZE(soc_fixed_pci_resources));
I also tried this, it's working after bootblock_systemagent_early_init function.
Ah, good catch, thanks. `bootblock_systemagent_early_init()` enables PCIEXBAR, which is needed to enable MCHBAR using `sa_set_pci_bar()`.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63890
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I59a9df141d475d122b22149ab18a1ae7cb068258
Gerrit-Change-Number: 63890
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Mon, 02 May 2022 17:02:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-MessageType: comment