Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44464 )
Change subject: mb/google/zork: Switch to normal read mode for EM100 ......................................................................
mb/google/zork: Switch to normal read mode for EM100
This change sets the EFS config for SPI read mode to normal read mode when using em100. With this, the boot is stable again without any random hangs in PSP.
BUG=b:164429022
Signed-off-by: Furquan Shaikh furquan@google.com Change-Id: I4cd3673dcc44a61905719a57f734df2fb9f4e6e2 --- M src/mainboard/google/zork/Kconfig 1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/44464/1
diff --git a/src/mainboard/google/zork/Kconfig b/src/mainboard/google/zork/Kconfig index c4a8f33..24c49c1 100644 --- a/src/mainboard/google/zork/Kconfig +++ b/src/mainboard/google/zork/Kconfig @@ -244,13 +244,13 @@
config EFS_SPI_READ_MODE int - default 4 if EM100 - default 2 + default 0 if EM100 # Normal read mode + default 2 # Dual IO (1-1-2)
config EFS_SPI_SPEED int - default 3 if EM100 - default 0 + default 3 if EM100 # 16.66 MHz + default 0 # 66.66 MHz
config EFS_SPI_MICRON_FLAG int
Matt Papageorge has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44464 )
Change subject: mb/google/zork: Switch to normal read mode for EM100 ......................................................................
Patch Set 1: Code-Review+1
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44464 )
Change subject: mb/google/zork: Switch to normal read mode for EM100 ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44464 )
Change subject: mb/google/zork: Switch to normal read mode for EM100 ......................................................................
mb/google/zork: Switch to normal read mode for EM100
This change sets the EFS config for SPI read mode to normal read mode when using em100. With this, the boot is stable again without any random hangs in PSP.
BUG=b:164429022
Signed-off-by: Furquan Shaikh furquan@google.com Change-Id: I4cd3673dcc44a61905719a57f734df2fb9f4e6e2 Reviewed-on: https://review.coreboot.org/c/coreboot/+/44464 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Matt Papageorge matthewpapa07@gmail.com Reviewed-by: Aaron Durbin adurbin@chromium.org --- M src/mainboard/google/zork/Kconfig 1 file changed, 4 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved Matt Papageorge: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/zork/Kconfig b/src/mainboard/google/zork/Kconfig index c4a8f33..24c49c1 100644 --- a/src/mainboard/google/zork/Kconfig +++ b/src/mainboard/google/zork/Kconfig @@ -244,13 +244,13 @@
config EFS_SPI_READ_MODE int - default 4 if EM100 - default 2 + default 0 if EM100 # Normal read mode + default 2 # Dual IO (1-1-2)
config EFS_SPI_SPEED int - default 3 if EM100 - default 0 + default 3 if EM100 # 16.66 MHz + default 0 # 66.66 MHz
config EFS_SPI_MICRON_FLAG int
-
Aaron Durbin (Code Review) -
Furquan Shaikh (Code Review)
-
Matt Papageorge (Code Review)
-
Patrick Georgi (Code Review)