Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29916 )
Change subject: Fix coreboot table record alignment to 8-byte boundary
......................................................................
Patch Set 5:
Yes, this patch can solve the problem under the RISC-V platform, but if you add a 128-bit new platform, you need to modify a lot of code.
We don't need to double the alignment for long-time stable data structures every time we want to support a new architecture, especially with a change that will affect all architectures at once. There are ways to access unaligned data... if RISC-V can't do it implicitly, just add the code for that.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29916
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1846be0e26ab3c81858d8cf727517e1462035e64
Gerrit-Change-Number: 29916
Gerrit-PatchSet: 5
Gerrit-Owner: Xiang Wang
wxjstz@126.com
Gerrit-Reviewer: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Shawn C
citypw@gmail.com
Gerrit-Reviewer: Xiang Wang
wxjstz@126.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-Comment-Date: Tue, 05 Feb 2019 20:50:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment