Attention is currently required from: Tim Crawford, Michał Żygowski, Jeremy Soller, Tim Wawrzynczak, Michał Kopeć.
Krystian Hebel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62496 )
Change subject: drivers/gfx/nvidia: Add Optimus driver based on Intel PCIe RTD3
......................................................................
Patch Set 5:
(3 comments)
File src/drivers/gfx/nvidia/optimus/optimus.c:
https://review.coreboot.org/c/coreboot/+/62496/comment/39ec2bb8_8922a763
PS5, Line 88: windows
Windows
https://review.coreboot.org/c/coreboot/+/62496/comment/e9f8a7ed_336add04
PS5, Line 137: if (config->reset_gpio.pin_count) {
I haven't seen the specification for this device, but shouldn't there be a delay between enabling clocks and de-asserting reset signal?
https://review.coreboot.org/c/coreboot/+/62496/comment/c1585144_4f078f4f
PS5, Line 261: const struct opregion rp_pci_config = OPREGION("PXCS", SYSTEMMEMORY, CONFIG_ECAM_MMCONF_BASE_ADDRESS | (parent->path.pci.devfn << 12), 0x1000);
Please split this line.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62496
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7bc6ec7a6a3e18417537b1f092a29972e9875282
Gerrit-Change-Number: 62496
Gerrit-PatchSet: 5
Gerrit-Owner: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Tim Crawford
tcrawford@system76.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Tim Crawford
tcrawford@system76.com
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Jeremy Soller
jeremy@system76.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Comment-Date: Mon, 02 May 2022 13:46:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment