Attention is currently required from: Nico Huber, Krishna Prabhakaran, Furquan Shaikh, Maulik V Vaghela, Selma Bensaid, Angel Pons, Subrata Banik, Patrick Rudolph. Meera Ravindranath has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52758 )
Change subject: drivers/intel/gma: Support IGD Opregion 2.1 ......................................................................
Patch Set 11:
(10 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52758/comment/f02cab9b_8afb48e2 PS10, Line 12: incase
in case
Done
File src/drivers/intel/gma/Kconfig:
https://review.coreboot.org/c/coreboot/+/52758/comment/b24ea982_d66f368e PS6, Line 149: config INTEL_GFX_IGD_OPREGION_2_1
Please align name with above convention […]
Done
https://review.coreboot.org/c/coreboot/+/52758/comment/ef21e89d_e207e1da PS6, Line 153: Support IGD Opregion version 2.1
Platform supports IGD opregion version 2.1 […]
Ack
File src/drivers/intel/gma/Kconfig:
https://review.coreboot.org/c/coreboot/+/52758/comment/b672964b_9bccfd5f PS10, Line 57: register (0xe0) rather than the SWSCI register (0xe8).
Place new Kconfig options here.
Done
https://review.coreboot.org/c/coreboot/+/52758/comment/a47d1bd0_dc34f2d1 PS10, Line 149: config INTEL_IGD_OPREGION_VERSION
This shouldn't be guarded by `if GFX_GMA`. […]
Done
https://review.coreboot.org/c/coreboot/+/52758/comment/093af3ac_f3b895bb PS10, Line 151: default 0x200
To handle the different RVDA meaning, as we don't support Opregion versions earlier than 2. […]
Done
File src/drivers/intel/gma/opregion.h:
https://review.coreboot.org/c/coreboot/+/52758/comment/871151e1_4c2e05e5 PS6, Line 32: #define IGD_OPREGION_VERSION 2
Can we put this macro as IF condition or select as per KCONFIG. […]
Done
File src/drivers/intel/gma/opregion.c:
https://review.coreboot.org/c/coreboot/+/52758/comment/e94b2e59_8e3bd218 PS6, Line 334:
nit: remove extra line added here
Done
https://review.coreboot.org/c/coreboot/+/52758/comment/9cfc1cbd_27d718c7 PS6, Line 364: if(CONFIG(INTEL_GFX_IGD_OPREGION_2_1))
We can remove this
Done
File src/drivers/intel/gma/opregion.c:
https://review.coreboot.org/c/coreboot/+/52758/comment/4b651a3c_bc2b2c21 PS10, Line 362: CONFIG_INTEL_IGD_OPREGION_VERSION
This now has a different value. Looks like it's not intentional? […]
Thanks for this, yes a left shift of 16 is required. Bits [31:24] - Major Version Number BCD Integer representing the major version of the OpRegion Bits [23:16] - Minor Version Number BCD Integer representing the minor version of the OpRegion