Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45901 )
Change subject: soc/intel/jasperlake: Set the GpioOverride configuration ......................................................................
Patch Set 10: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/45901/10/src/soc/intel/jasperlake/r... File src/soc/intel/jasperlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/45901/10/src/soc/intel/jasperlake/r... PS10, Line 123: before moved "programmed before" ?
https://review.coreboot.org/c/coreboot/+/45901/10/src/soc/intel/jasperlake/r... PS10, Line 123: setings typo: set*t*ings