Attention is currently required from: Arthur Heymans, Kapil Porwal, Nick Vaccaro, Werner Zeh.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80924?usp=email )
Change subject: soc/intel/cmn/cse: Deprecate CONFIG_SOC_INTEL_CSE_RW_VERSION
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/common/block/cse/Kconfig:
https://review.coreboot.org/c/coreboot/+/80924/comment/1acb1c25_36d9fac4 :
PS1, Line 236: enabling automatic detection
OK, then it is more about not specifying the CSE version at all in which case the automatic version discovery will take place, right? Maybe you can rephrase then a bit, e.g.:
"This config may be deprecated in the future. Consider not providing a version here and let the CSE version be automatically queried from the CSE binary at build time (available with Meteor Lake and following platforms)."
But it is up to you to decide, hence I will mark this as resolved.
thanks for the suggestion, i have updated the help text now.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80924?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8c3e5c759e4d9a43c3bce3a0c032086f17592a67
Gerrit-Change-Number: 80924
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Mon, 04 Mar 2024 18:18:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Gerrit-MessageType: comment