Change in coreboot[master]: soc/intel/tigerlake: Correct GPIO community PID configuration

[EricR Lai (Code Review)]

EricR Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41725 )

Change subject: soc/intel/tigerlake: Correct GPIO community PID configuration
......................................................................

soc/intel/tigerlake: Correct GPIO community PID configuration

Current implementation retuns the incorrect GPIO community PID.
The GPIO community index 3 should return PID for COMM_4 and index
4 should return PID for COMM_5.

TEST=Verify PCR port id is correct for each community.

Signed-off-by: Eric Lai 
Change-Id: I5dc48e5b31f43853b3a613c17f13f7df71f1fbfa
---
M src/soc/intel/tigerlake/acpi/gpio.asl
1 file changed, 5 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/41725/1

diff --git a/src/soc/intel/tigerlake/acpi/gpio.asl b/src/soc/intel/tigerlake/acpi/gpio.asl
index 6206eb7..b17abfe 100644
--- a/src/soc/intel/tigerlake/acpi/gpio.asl
+++ b/src/soc/intel/tigerlake/acpi/gpio.asl
@@ -106,19 +106,19 @@
 {
    Switch (ToInteger (Arg0))
    {
-		Case (0) {
+		Case (COMM_0) {
    		Local0 = PID_GPIOCOM0
    	}
-		Case (1) {
+		Case (COMM_1) {
    		Local0 = PID_GPIOCOM1
    	}
-		Case (2) {
+		Case (COMM_2) {
    		Local0 = PID_GPIOCOM2
    	}
-		Case (4) {
+		Case (COMM_4) {
    		Local0 = PID_GPIOCOM4
    	}
-		Case (5) {
+		Case (COMM_5) {
    		Local0 = PID_GPIOCOM5
    	}
    	Default {

[EricR Lai (Code Review)]

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41725 )

Change subject: soc/intel/tigerlake: Correct GPIO community PID configuration
......................................................................

Patch Set 1:

I just copy your comment.

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41725 )

Change subject: soc/intel/tigerlake: Correct GPIO community PID configuration
......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/c/coreboot/+/41725/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/41725/1//COMMIT_MSG@9 
PS1, Line 9: retuns
returns

https://review.coreboot.org/c/coreboot/+/41725/1//COMMIT_MSG@13 
PS1, Line 13: TEST=Verify PCR port id is correct for each community.
Looking at what logs or using what tool?

[EricR Lai (Code Review)]

Hello build bot (Jenkins), Subrata Banik, Furquan Shaikh, Tim Wawrzynczak, Aamir Bohra, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/41725

to look at the new patch set (#2).

Change subject: soc/intel/tigerlake: Correct GPIO community PID configuration
......................................................................

soc/intel/tigerlake: Correct GPIO community PID configuration

Current implementation returns the incorrect GPIO community PID.
The GPIO community index 3 should return PID for COMM_4 and index
4 should return PID for COMM_5.

TEST=Verify PCR port id is correct for each community.

Signed-off-by: Eric Lai 
Change-Id: I5dc48e5b31f43853b3a613c17f13f7df71f1fbfa
---
M src/soc/intel/tigerlake/acpi/gpio.asl
1 file changed, 5 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/41725/2

[EricR Lai (Code Review)]

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41725 )

Change subject: soc/intel/tigerlake: Correct GPIO community PID configuration
......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/41725/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/41725/1//COMMIT_MSG@9 
PS1, Line 9: retuns
> returns

Done

https://review.coreboot.org/c/coreboot/+/41725/1//COMMIT_MSG@13 
PS1, Line 13: TEST=Verify PCR port id is correct for each community.
> Looking at what logs or using what tool?

Add printf log and check kernel log with aml_debug enable. Should I add this in the comment?

[Aamir Bohra (Code Review)]

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41725 )

Change subject: soc/intel/tigerlake: Correct GPIO community PID configuration
......................................................................

Patch Set 2: Code-Review+2

[Wonkyu Kim (Code Review)]

Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41725 )

Change subject: soc/intel/tigerlake: Correct GPIO community PID configuration
......................................................................

Patch Set 2: Code-Review+1

[EricR Lai (Code Review)]

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41725 )

Change subject: soc/intel/tigerlake: Correct GPIO community PID configuration
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41725/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/41725/1//COMMIT_MSG@13 
PS1, Line 13: TEST=Verify PCR port id is correct for each community.
> Add printf log and check kernel log with aml_debug enable. […]

Done

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41725 )

Change subject: soc/intel/tigerlake: Correct GPIO community PID configuration
......................................................................

Patch Set 3: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41725 )

Change subject: soc/intel/tigerlake: Correct GPIO community PID configuration
......................................................................

soc/intel/tigerlake: Correct GPIO community PID configuration

Current implementation returns the incorrect GPIO community PID.
The GPIO community index 3 should return PID for COMM_4 and index
4 should return PID for COMM_5.

TEST=Verify PCR port id is correct for each community.

Signed-off-by: Eric Lai 
Change-Id: I5dc48e5b31f43853b3a613c17f13f7df71f1fbfa
Reviewed-on: https://review.coreboot.org/c/coreboot/+/41725
Reviewed-by: Tim Wawrzynczak 
Reviewed-by: Aamir Bohra 
Reviewed-by: Wonkyu Kim 
Tested-by: build bot (Jenkins) 
---
M src/soc/intel/tigerlake/acpi/gpio.asl
1 file changed, 5 insertions(+), 5 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Aamir Bohra: Looks good to me, approved
  Wonkyu Kim: Looks good to me, but someone else must approve
  Tim Wawrzynczak: Looks good to me, approved

diff --git a/src/soc/intel/tigerlake/acpi/gpio.asl b/src/soc/intel/tigerlake/acpi/gpio.asl
index 6206eb7..b17abfe 100644
--- a/src/soc/intel/tigerlake/acpi/gpio.asl
+++ b/src/soc/intel/tigerlake/acpi/gpio.asl
@@ -106,19 +106,19 @@
 {
    Switch (ToInteger (Arg0))
    {
-		Case (0) {
+		Case (COMM_0) {
    		Local0 = PID_GPIOCOM0
    	}
-		Case (1) {
+		Case (COMM_1) {
    		Local0 = PID_GPIOCOM1
    	}
-		Case (2) {
+		Case (COMM_2) {
    		Local0 = PID_GPIOCOM2
    	}
-		Case (4) {
+		Case (COMM_4) {
    		Local0 = PID_GPIOCOM4
    	}
-		Case (5) {
+		Case (COMM_5) {
    		Local0 = PID_GPIOCOM5
    	}
    	Default {