Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35921 )
Change subject: mb/google/glados: port to FSP 2.0
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35921/1/src/mainboard/google/glados...
File src/mainboard/google/glados/Kconfig:
https://review.coreboot.org/c/coreboot/+/35921/1/src/mainboard/google/glados...
PS1, Line 23: select MAINBOARD_HAS_LIBGFXINIT
we don't want to add this without the required libgfxinit file and makefile change, or before the current CDCLK changes are merged in
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35921
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id747ef484dfdcb2d346f817976f52073912468d0
Gerrit-Change-Number: 35921
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 09 Oct 2019 21:03:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment