[S] Change in coreboot[main]: soc/intel/xeon_sp: Redefine data types for 6th Gen adoption

[Shuo Liu (Code Review)]

Attention is currently required from: Arthur Heymans, Christian Walter, David Hendricks, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Nico Huber, Patrick Rudolph, TangYiwei, Tim Chu.

Shuo Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81040?usp=email )

Change subject: soc/intel/xeon_sp: Redefine data types for 6th Gen adoption
......................................................................

Patch Set 10:

(2 comments)

Patchset:

PS9:
> If possible, please contain the changes within `soc_util.h`. […]

Good suggestion, thanks!

File src/soc/intel/xeon_sp/include/soc/fsp_adoption.h:

https://review.coreboot.org/c/coreboot/+/81040/comment/1cf5c926_dd7353be :
PS9, Line 21: #define xSTACK_RES UDS_STACK_RES
> If the types are compatible, wouldn't it be enough to […]

It will work, but personally I'm inclined to keep the C code changes, since the redefine (xSTACK_RES) will reminder developers that this is a redefined symbol.

This is aligned with how FSP driver handles a similar issue, in src/drivers/intel/fsp2_0/include/fsp/util.h

#if CONFIG(PLATFORM_USES_FSP2_4)
#define FSPM_ARCHx_UPD FSPM_ARCH2_UPD
#define FSPS_ARCHx_UPD FSPS_ARCH2_UPD
#else
#define FSPM_ARCHx_UPD FSPM_ARCH_UPD
#define FSPS_ARCHx_UPD FSPS_ARCH_UPD
#endif