ron minnich has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37573 )
Change subject: Allow the user to control RELOCATABLE_RAMSTAGE ......................................................................
Allow the user to control RELOCATABLE_RAMSTAGE
By default, on x86, relocatable ramstage is chosen.
There are some cases where we wish to allow the developer to control this setting.
Change-Id: Idf60b647a8e3f02b3f88589d30eff9c03515b04c Signed-off-by: Ronald G. Minnich rminnich@gmail.com --- M src/Kconfig 1 file changed, 9 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/37573/1
diff --git a/src/Kconfig b/src/Kconfig index 2e06299..b82f484 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -269,15 +269,18 @@ default y
config RELOCATABLE_RAMSTAGE - bool + bool "Build a relocatable ramstage" default !NO_RELOCATABLE_RAMSTAGE select RELOCATABLE_MODULES help - The reloctable ramstage support allows for the ramstage to be built - as a relocatable module. The stage loader can identify a place - out of the OS way so that copying memory is unnecessary during an S3 - wake. When selecting this option the romstage is responsible for - determing a stack location to use for loading the ramstage. + The relocatable ramstage support allows for the ramstage to be built + as a relocatable module. The stage loader can identify a place + out of the OS way so that copying memory is unnecessary during an S3 + wake. When selecting this option the romstage is responsible for + determining a stack location to use for loading the ramstage. + You almost always want this on x86, and almost never anywhere + else. Make sure you understand the implications of not using + the default choice.
config TSEG_STAGE_CACHE bool
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37573 )
Change subject: Allow the user to control RELOCATABLE_RAMSTAGE ......................................................................
Patch Set 1: Code-Review+2
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37573 )
Change subject: Allow the user to control RELOCATABLE_RAMSTAGE ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37573/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37573/1//COMMIT_MSG@12 PS1, Line 12: developer to control this setting. We try not to expose items in menuconfig that results with either not building, or worse, not booting. Can you elaborate about this future development?
If future development adds new Kconfigs, you could possibly have 'select NO_RELOCATABLE_RAMSTAGE' there for the same effect.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37573 )
Change subject: Allow the user to control RELOCATABLE_RAMSTAGE ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37573/1/src/Kconfig File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/37573/1/src/Kconfig@272 PS1, Line 272: bool "Build a relocatable ramstage" For the current payloads/payloader use-case, could we just override the default? e.g.
default n if PAYLOAD_PAYLOADER
or keep NO_RELOCATABLE_RAMSTAGE and select it from payloads/Kconfig?
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37573 )
Change subject: Allow the user to control RELOCATABLE_RAMSTAGE ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37573/1/src/Kconfig File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/37573/1/src/Kconfig@272 PS1, Line 272: bool "Build a relocatable ramstage"
For the current payloads/payloader use-case, could we just override […]
Yeah, I would actually go with first option and remove NO_RELOCATABLE_RAMSTAGE.
You can also limit the visibility of this, but so far I don't understand the situation where you would have a choice to make here.
bool prompt "xxx" if PAYLOAD_PAYLOADER
Hello Subrata Banik, Lean Sheng Tan, Jeremy Soller, build bot (Jenkins), Nico Huber, Martin Roth, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37573
to look at the new patch set (#2).
Change subject: Allow the user to control RELOCATABLE_RAMSTAGE ......................................................................
Allow the user to control RELOCATABLE_RAMSTAGE
By default, on x86, relocatable ramstage is chosen.
There are some cases where we wish to allow the developer to control this setting. We will present such a case in a following commit, but that case is not logically part of this commit.
Change-Id: Idf60b647a8e3f02b3f88589d30eff9c03515b04c Signed-off-by: Ronald G. Minnich rminnich@gmail.com --- M src/Kconfig 1 file changed, 9 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/37573/2
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37573 )
Change subject: Allow the user to control RELOCATABLE_RAMSTAGE ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37573/1/src/Kconfig File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/37573/1/src/Kconfig@272 PS1, Line 272: bool "Build a relocatable ramstage"
Yeah, I would actually go with first option and remove NO_RELOCATABLE_RAMSTAGE. […]
"if PAYLOAD_PAYLOADER" requires building the image with that payload through the makefiles, which may not be desirable.
-
Kyösti Mälkki (Code Review) -
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)
-
ron minnich (Code Review)
-
Subrata Banik (Code Review)