Change in ...coreboot[master]: soc/amd/common/lpc: Add Picasso ID

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

Marshall Dawson (Code Review)

25 Jun 2019 25 Jun '19

2:04 a.m.

Marshall Dawson has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33758

Change subject: soc/amd/common/lpc: Add Picasso ID ......................................................................

soc/amd/common/lpc: Add Picasso ID

Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com Change-Id: I02e6fdcd6685e0dd3fa7872b054ebe508157a0ed --- M src/soc/amd/common/block/lpc/lpc.c 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/33758/1

diff --git a/src/soc/amd/common/block/lpc/lpc.c b/src/soc/amd/common/block/lpc/lpc.c index b896517..c794601 100644 --- a/src/soc/amd/common/block/lpc/lpc.c +++ b/src/soc/amd/common/block/lpc/lpc.c @@ -337,6 +337,7 @@ static const unsigned short pci_device_ids[] = { PCI_DEVICE_ID_AMD_SB900_LPC, PCI_DEVICE_ID_AMD_CZ_LPC, + PCI_DEVICE_ID_AMD_PCO_LPC, 0 }; static const struct pci_driver lpc_driver __pci_driver = {

Attachments:

attachment.htm (text/html — 2.3 KB)

Show replies by date

Richard Spiegel (Code Review)

2 Jul 2 Jul

5:43 p.m.

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33758 )

Change subject: soc/amd/common/lpc: Add Picasso ID ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/33758/2/src/soc/amd/common/block/lpc/lpc.c File src/soc/amd/common/block/lpc/lpc.c:

https://review.coreboot.org/#/c/33758/2/src/soc/amd/common/block/lpc/lpc.c@3... PS2, Line 340: PCI_DEVICE_ID_AMD_PCO_LPC Not yet defined. I downloaded this patch and did a search... it's used here, but defined nowhere.

-- To view, visit https://review.coreboot.org/c/coreboot/+/33758 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I02e6fdcd6685e0dd3fa7872b054ebe508157a0ed Gerrit-Change-Number: 33758 Gerrit-PatchSet: 2 Gerrit-Owner: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Richard Spiegel richard.spiegel@silverbackltd.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 02 Jul 2019 15:43:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

5:57 p.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33758 )

Change subject: soc/amd/common/lpc: Add Picasso ID ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/33758/2/src/soc/amd/common/block/lpc/lpc.c File src/soc/amd/common/block/lpc/lpc.c:

https://review.coreboot.org/#/c/33758/2/src/soc/amd/common/block/lpc/lpc.c@3... PS2, Line 340: PCI_DEVICE_ID_AMD_PCO_LPC

...

Not yet defined. I downloaded this patch and did a search... it's used here, but defined nowhere.

src/include/device/pci_ids.h:#define PCI_DEVICE_ID_AMD_PCO_LPC 0x790e

(maybe rebase on master)

-- To view, visit https://review.coreboot.org/c/coreboot/+/33758 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I02e6fdcd6685e0dd3fa7872b054ebe508157a0ed Gerrit-Change-Number: 33758 Gerrit-PatchSet: 2 Gerrit-Owner: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Richard Spiegel richard.spiegel@silverbackltd.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 02 Jul 2019 15:57:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Richard Spiegel richard.spiegel@silverbackltd.com Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

6:04 p.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33758 )

Change subject: soc/amd/common/lpc: Add Picasso ID ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/33758/2/src/soc/amd/common/block/lpc/lpc.c File src/soc/amd/common/block/lpc/lpc.c:

https://review.coreboot.org/#/c/33758/2/src/soc/amd/common/block/lpc/lpc.c@3... PS2, Line 340: PCI_DEVICE_ID_AMD_PCO_LPC

...

src/include/device/pci_ids.h:#define PCI_DEVICE_ID_AMD_PCO_LPC 0x790e […]

https://review.coreboot.org/c/coreboot/+/33748

-- To view, visit https://review.coreboot.org/c/coreboot/+/33758 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I02e6fdcd6685e0dd3fa7872b054ebe508157a0ed Gerrit-Change-Number: 33758 Gerrit-PatchSet: 2 Gerrit-Owner: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Richard Spiegel richard.spiegel@silverbackltd.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 02 Jul 2019 16:04:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: HAOUAS Elyes ehaouas@noos.fr Comment-In-Reply-To: Richard Spiegel richard.spiegel@silverbackltd.com Gerrit-MessageType: comment

Marshall Dawson (Code Review)

6:28 p.m.

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33758 )

Change subject: soc/amd/common/lpc: Add Picasso ID ......................................................................

Patch Set 2:

...

https://review.coreboot.org/c/coreboot/+/33748

Right. The IDs were put into the generic file instead of being defined in soc.

-- To view, visit https://review.coreboot.org/c/coreboot/+/33758 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I02e6fdcd6685e0dd3fa7872b054ebe508157a0ed Gerrit-Change-Number: 33758 Gerrit-PatchSet: 2 Gerrit-Owner: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Richard Spiegel richard.spiegel@silverbackltd.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 02 Jul 2019 16:28:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Martin Roth (Code Review)

4 Jul 4 Jul

12:25 a.m.

New subject: Change in coreboot[master]: soc/amd/common/lpc: Add Picasso ID

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33758 )

Change subject: soc/amd/common/lpc: Add Picasso ID ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/33758 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I02e6fdcd6685e0dd3fa7872b054ebe508157a0ed Gerrit-Change-Number: 33758 Gerrit-PatchSet: 3 Gerrit-Owner: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Richard Spiegel richard.spiegel@silverbackltd.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 03 Jul 2019 22:25:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Martin Roth (Code Review)

12:25 a.m.

New subject: Change in coreboot[master]: soc/amd/common/lpc: Add Picasso ID

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33758 )

Change subject: soc/amd/common/lpc: Add Picasso ID ......................................................................

soc/amd/common/lpc: Add Picasso ID

Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com Change-Id: I02e6fdcd6685e0dd3fa7872b054ebe508157a0ed Reviewed-on: https://review.coreboot.org/c/coreboot/+/33758 Reviewed-by: Martin Roth martinroth@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/amd/common/block/lpc/lpc.c 1 file changed, 1 insertion(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved

-- To view, visit https://review.coreboot.org/c/coreboot/+/33758 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I02e6fdcd6685e0dd3fa7872b054ebe508157a0ed Gerrit-Change-Number: 33758 Gerrit-PatchSet: 4 Gerrit-Owner: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Richard Spiegel richard.spiegel@silverbackltd.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1763

days inactive

1771

days old

coreboot-gerrit@coreboot.org

6 comments

4 participants

tags (0)

participants (4)

HAOUAS Elyes (Code Review)
Marshall Dawson (Code Review)
Martin Roth (Code Review)
Richard Spiegel (Code Review)