HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33758 )
Change subject: soc/amd/common/lpc: Add Picasso ID
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/33758/2/src/soc/amd/common/block/lpc/lpc.c
File src/soc/amd/common/block/lpc/lpc.c:
https://review.coreboot.org/#/c/33758/2/src/soc/amd/common/block/lpc/lpc.c@3...
PS2, Line 340: PCI_DEVICE_ID_AMD_PCO_LPC
Not yet defined. I downloaded this patch and did a search... it's used here, but defined nowhere.
src/include/device/pci_ids.h:#define PCI_DEVICE_ID_AMD_PCO_LPC 0x790e
(maybe rebase on master)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33758
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I02e6fdcd6685e0dd3fa7872b054ebe508157a0ed
Gerrit-Change-Number: 33758
Gerrit-PatchSet: 2
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 02 Jul 2019 15:57:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-MessageType: comment