Marshall Dawson has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33757
Change subject: soc/amd/common/iommu: Add Picasso ID ......................................................................
soc/amd/common/iommu: Add Picasso ID
Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com Change-Id: Ib000e12cd568dd83b9533efe66e67878b806b3f3 --- M src/soc/amd/common/block/iommu/iommu.c 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/33757/1
diff --git a/src/soc/amd/common/block/iommu/iommu.c b/src/soc/amd/common/block/iommu/iommu.c index 1c982ca..c068501 100644 --- a/src/soc/amd/common/block/iommu/iommu.c +++ b/src/soc/amd/common/block/iommu/iommu.c @@ -49,6 +49,7 @@ static const unsigned short pci_device_ids[] = { PCI_DEVICE_ID_AMD_15H_MODEL_303F_NB_IOMMU, PCI_DEVICE_ID_AMD_15H_MODEL_707F_NB_IOMMU, + PCI_DEVICE_ID_AMD_17H_MODEL_101F_NB_IOMMU, 0 };
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33757 )
Change subject: soc/amd/common/iommu: Add Picasso ID ......................................................................
Patch Set 2: Code-Review+2
Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33757 )
Change subject: soc/amd/common/iommu: Add Picasso ID ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/33757/2/src/soc/amd/common/block/iommu/iommu... File src/soc/amd/common/block/iommu/iommu.c:
https://review.coreboot.org/#/c/33757/2/src/soc/amd/common/block/iommu/iommu... PS2, Line 52: PCI_DEVICE_ID_AMD_17H_MODEL_101F_NB_IOMMU, Not yet defined. I downloaded this patch and did a search... it's used here, but defined nowhere.
Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33757 )
Change subject: soc/amd/common/iommu: Add Picasso ID ......................................................................
Patch Set 2:
Patch Set 2: Code-Review+2
Not yet... good, but where is it defined?
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33757 )
Change subject: soc/amd/common/iommu: Add Picasso ID ......................................................................
Patch Set 2:
Patch Set 2:
Patch Set 2: Code-Review+2
Not yet... good, but where is it defined?
coreboot$ git grep PCI_DEVICE_ID_AMD_17H_MODEL_101F_NB_IOMMU src/include/device/pci_ids.h:#define PCI_DEVICE_ID_AMD_17H_MODEL_101F_NB_IOMMU 0x15d1
Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33757 )
Change subject: soc/amd/common/iommu: Add Picasso ID ......................................................................
Patch Set 2: Code-Review+2
Patch Set 2:
Patch Set 2:
Patch Set 2: Code-Review+2
Not yet... good, but where is it defined?
coreboot$ git grep PCI_DEVICE_ID_AMD_17H_MODEL_101F_NB_IOMMU src/include/device/pci_ids.h:#define PCI_DEVICE_ID_AMD_17H_MODEL_101F_NB_IOMMU 0x15d1
Ok, agree.
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33757 )
Change subject: soc/amd/common/iommu: Add Picasso ID ......................................................................
soc/amd/common/iommu: Add Picasso ID
Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com Change-Id: Ib000e12cd568dd83b9533efe66e67878b806b3f3 Reviewed-on: https://review.coreboot.org/c/coreboot/+/33757 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Reviewed-by: Richard Spiegel richard.spiegel@silverbackltd.com --- M src/soc/amd/common/block/iommu/iommu.c 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved Richard Spiegel: Looks good to me, approved
diff --git a/src/soc/amd/common/block/iommu/iommu.c b/src/soc/amd/common/block/iommu/iommu.c index 1c982ca..c068501 100644 --- a/src/soc/amd/common/block/iommu/iommu.c +++ b/src/soc/amd/common/block/iommu/iommu.c @@ -49,6 +49,7 @@ static const unsigned short pci_device_ids[] = { PCI_DEVICE_ID_AMD_15H_MODEL_303F_NB_IOMMU, PCI_DEVICE_ID_AMD_15H_MODEL_707F_NB_IOMMU, + PCI_DEVICE_ID_AMD_17H_MODEL_101F_NB_IOMMU, 0 };