Duan huayang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42502 )
Change subject: google/kukui: Add Hynix 4GB discrete LPDDR4X DDR support ......................................................................
google/kukui: Add Hynix 4GB discrete LPDDR4X DDR support
Support 4GB H9HCNNNCPMMLXR-NEE discrete DDR bootup.
BUG=b:156691665 BRANCH=none TEST=Boots correctly and stress test passes on Kukui.
Change-Id: I0b29cc1cf0d51eb9d6af112858563193ffa88652 Signed-off-by: Huayang Duan huayang.duan@mediatek.com --- M src/mainboard/google/kukui/sdram_configs.c M src/mainboard/google/kukui/sdram_params/Makefile.inc A src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-H9HCNNNCPMMLXR-NEE-4GB.c 3 files changed, 29 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/42502/1
diff --git a/src/mainboard/google/kukui/sdram_configs.c b/src/mainboard/google/kukui/sdram_configs.c index 73bd2f8..ed30d70 100644 --- a/src/mainboard/google/kukui/sdram_configs.c +++ b/src/mainboard/google/kukui/sdram_configs.c @@ -15,6 +15,7 @@ [6] = "sdram-lpddr4x-KMDV6001DA-B620-4GB", [7] = "sdram-lpddr4x-SDADA4CR-128G-4GB", [8] = "sdram-lpddr4x-K4UBE3D4AA-MGCL-4GB", + [10] = "sdram-lpddr4x-H9HCNNNCPMMLXR-NEE-4GB", };
static struct sdram_params params; diff --git a/src/mainboard/google/kukui/sdram_params/Makefile.inc b/src/mainboard/google/kukui/sdram_params/Makefile.inc index 4d91998..af13aa1 100644 --- a/src/mainboard/google/kukui/sdram_params/Makefile.inc +++ b/src/mainboard/google/kukui/sdram_params/Makefile.inc @@ -7,6 +7,7 @@ sdram-params += sdram-lpddr4x-MT29VZZZAD8DQKSL-4GB sdram-params += sdram-lpddr4x-KMDV6001DA-B620-4GB sdram-params += sdram-lpddr4x-SDADA4CR-128G-4GB +sdram-params += sdram-lpddr4x-H9HCNNNCPMMLXR-NEE-4GB
$(foreach params,$(sdram-params), \ $(eval cbfs-files-y += $(params)) \ diff --git a/src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-H9HCNNNCPMMLXR-NEE-4GB.c b/src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-H9HCNNNCPMMLXR-NEE-4GB.c new file mode 100644 index 0000000..6b53bcc --- /dev/null +++ b/src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-H9HCNNNCPMMLXR-NEE-4GB.c @@ -0,0 +1,27 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* This file is part of the coreboot project. */ + +#include <soc/emi.h> + +struct sdram_params params = { + .source = DRAMC_PARAM_SOURCE_SDRAM_CONFIG, + .frequency = 1600, + .wr_level = { + [CHANNEL_A] = { {0x22, 0x1b}, {0x22, 0x19} }, + [CHANNEL_B] = { {0x24, 0x20}, {0x25, 0x20} } + }, + .cbt_cs_dly = { + [CHANNEL_A] = {0x0, 0x0}, + [CHANNEL_B] = {0x0, 0x0} + }, + .cbt_final_vref = { + [CHANNEL_A] = {0x52, 0x52}, + [CHANNEL_B] = {0x52, 0x52} + }, + .emi_cona_val = 0xF053F154, + .emi_conh_val = 0x44440003, + .emi_conf_val = 0x00421000, + .chn_emi_cona_val = {0x0444F051, 0x0444F051}, + .cbt_mode_extern = CBT_NORMAL_MODE, + .delay_cell_unit = 868, +};
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42502 )
Change subject: google/kukui: Add Hynix 4GB discrete LPDDR4X DDR support ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42502/1/src/mainboard/google/kukui/... File src/mainboard/google/kukui/sdram_configs.c:
https://review.coreboot.org/c/coreboot/+/42502/1/src/mainboard/google/kukui/... PS1, Line 18: [10] = "sdram-lpddr4x-H9HCNNNCPMMLXR-NEE-4GB", code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/42502/1/src/mainboard/google/kukui/... PS1, Line 18: [10] = "sdram-lpddr4x-H9HCNNNCPMMLXR-NEE-4GB", please, no spaces at the start of a line
Hello Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42502
to look at the new patch set (#2).
Change subject: google/kukui: Add Hynix 4GB discrete LPDDR4X DDR support ......................................................................
google/kukui: Add Hynix 4GB discrete LPDDR4X DDR support
Support 4GB H9HCNNNCPMMLXR-NEE discrete DDR bootup.
BUG=b:156691665 BRANCH=none TEST=Boots correctly and stress test passes on Kukui.
Change-Id: I0b29cc1cf0d51eb9d6af112858563193ffa88652 Signed-off-by: Huayang Duan huayang.duan@mediatek.com --- M src/mainboard/google/kukui/sdram_configs.c M src/mainboard/google/kukui/sdram_params/Makefile.inc A src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-H9HCNNNCPMMLXR-NEE-4GB.c 3 files changed, 29 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/42502/2
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42502 )
Change subject: google/kukui: Add Hynix 4GB discrete LPDDR4X DDR support ......................................................................
Patch Set 2:
Hi Huayang
Any reason to skip #9?
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42502 )
Change subject: google/kukui: Add Hynix 4GB discrete LPDDR4X DDR support ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42502/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42502/2//COMMIT_MSG@7 PS2, Line 7: google mb/google
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42502 )
Change subject: google/kukui: Add Hynix 4GB discrete LPDDR4X DDR support ......................................................................
Patch Set 2: Code-Review+1
I can +2 once you fixed the comment as yupingso@ suggested.
Hello Hung-Te Lin, build bot (Jenkins), Patrick Georgi, Martin Roth, Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42502
to look at the new patch set (#3).
Change subject: mb/google: Add Hynix 4GB discrete LPDDR4X DDR support ......................................................................
mb/google: Add Hynix 4GB discrete LPDDR4X DDR support
Support 4GB H9HCNNNCPMMLXR-NEE discrete DDR bootup.
BUG=b:156691665 BRANCH=none TEST=Boots correctly and stress test passes on Kukui.
Change-Id: I0b29cc1cf0d51eb9d6af112858563193ffa88652 Signed-off-by: Huayang Duan huayang.duan@mediatek.com --- M src/mainboard/google/kukui/sdram_configs.c M src/mainboard/google/kukui/sdram_params/Makefile.inc A src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-H9HCNNNCPMMLXR-NEE-4GB.c 3 files changed, 29 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/42502/3
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42502 )
Change subject: mb/google: Add Hynix 4GB discrete LPDDR4X DDR support ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/42502/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42502/3//COMMIT_MSG@7 PS3, Line 7: mb/google mb/google/kukui
https://review.coreboot.org/c/coreboot/+/42502/3//COMMIT_MSG@13 PS3, Line 13: TEST=Boots correctly and stress test passes on Kukui. Please add the command of the stress test.
https://review.coreboot.org/c/coreboot/+/42502/3/src/mainboard/google/kukui/... File src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-H9HCNNNCPMMLXR-NEE-4GB.c:
https://review.coreboot.org/c/coreboot/+/42502/3/src/mainboard/google/kukui/... PS3, Line 2: /* This file is part of the coreboot project. */ I believe the second line can be dropped.
Hello Hung-Te Lin, build bot (Jenkins), Patrick Georgi, Martin Roth, Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42502
to look at the new patch set (#4).
Change subject: mb/google/kukui: Add Hynix 4GB discrete LPDDR4X DDR support ......................................................................
mb/google/kukui: Add Hynix 4GB discrete LPDDR4X DDR support
Support 4GB H9HCNNNCPMMLXR-NEE discrete DDR bootup.
BUG=b:156691665 BRANCH=none TEST=Boots correctly and stress test passes on Kukui. test cmd: memtester 1000M
Change-Id: I0b29cc1cf0d51eb9d6af112858563193ffa88652 Signed-off-by: Huayang Duan huayang.duan@mediatek.com --- M src/mainboard/google/kukui/sdram_configs.c M src/mainboard/google/kukui/sdram_params/Makefile.inc A src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-H9HCNNNCPMMLXR-NEE-4GB.c 3 files changed, 28 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/42502/4
Duan huayang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42502 )
Change subject: mb/google/kukui: Add Hynix 4GB discrete LPDDR4X DDR support ......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/c/coreboot/+/42502/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42502/2//COMMIT_MSG@7 PS2, Line 7: google
mb/google
Done
https://review.coreboot.org/c/coreboot/+/42502/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42502/3//COMMIT_MSG@7 PS3, Line 7: mb/google
mb/google/kukui
Done
https://review.coreboot.org/c/coreboot/+/42502/3//COMMIT_MSG@13 PS3, Line 13: TEST=Boots correctly and stress test passes on Kukui.
Please add the command of the stress test.
Done
https://review.coreboot.org/c/coreboot/+/42502/3/src/mainboard/google/kukui/... File src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-H9HCNNNCPMMLXR-NEE-4GB.c:
https://review.coreboot.org/c/coreboot/+/42502/3/src/mainboard/google/kukui/... PS3, Line 2: /* This file is part of the coreboot project. */
I believe the second line can be dropped.
Done
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42502 )
Change subject: mb/google/kukui: Add Hynix 4GB discrete LPDDR4X DDR support ......................................................................
Patch Set 4: Code-Review+2
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42502 )
Change subject: mb/google/kukui: Add Hynix 4GB discrete LPDDR4X DDR support ......................................................................
Patch Set 4: Code-Review+1
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42502 )
Change subject: mb/google/kukui: Add Hynix 4GB discrete LPDDR4X DDR support ......................................................................
Patch Set 4: Code-Review+1
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42502 )
Change subject: mb/google/kukui: Add Hynix 4GB discrete LPDDR4X DDR support ......................................................................
mb/google/kukui: Add Hynix 4GB discrete LPDDR4X DDR support
Support 4GB H9HCNNNCPMMLXR-NEE discrete DDR bootup.
BUG=b:156691665 BRANCH=none TEST=Boots correctly and stress test passes on Kukui. test cmd: memtester 1000M
Change-Id: I0b29cc1cf0d51eb9d6af112858563193ffa88652 Signed-off-by: Huayang Duan huayang.duan@mediatek.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/42502 Reviewed-by: Hung-Te Lin hungte@chromium.org Reviewed-by: Yu-Ping Wu yupingso@google.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/kukui/sdram_configs.c M src/mainboard/google/kukui/sdram_params/Makefile.inc A src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-H9HCNNNCPMMLXR-NEE-4GB.c 3 files changed, 28 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Hung-Te Lin: Looks good to me, approved Yu-Ping Wu: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/kukui/sdram_configs.c b/src/mainboard/google/kukui/sdram_configs.c index 77aaca7..c1e75ef6 100644 --- a/src/mainboard/google/kukui/sdram_configs.c +++ b/src/mainboard/google/kukui/sdram_configs.c @@ -14,6 +14,7 @@ [6] = "sdram-lpddr4x-KMDV6001DA-B620-4GB", [7] = "sdram-lpddr4x-SDADA4CR-128G-4GB", [8] = "sdram-lpddr4x-K4UBE3D4AA-MGCL-4GB", + [10] = "sdram-lpddr4x-H9HCNNNCPMMLXR-NEE-4GB", };
static struct sdram_params params; diff --git a/src/mainboard/google/kukui/sdram_params/Makefile.inc b/src/mainboard/google/kukui/sdram_params/Makefile.inc index 4d91998..af13aa1 100644 --- a/src/mainboard/google/kukui/sdram_params/Makefile.inc +++ b/src/mainboard/google/kukui/sdram_params/Makefile.inc @@ -7,6 +7,7 @@ sdram-params += sdram-lpddr4x-MT29VZZZAD8DQKSL-4GB sdram-params += sdram-lpddr4x-KMDV6001DA-B620-4GB sdram-params += sdram-lpddr4x-SDADA4CR-128G-4GB +sdram-params += sdram-lpddr4x-H9HCNNNCPMMLXR-NEE-4GB
$(foreach params,$(sdram-params), \ $(eval cbfs-files-y += $(params)) \ diff --git a/src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-H9HCNNNCPMMLXR-NEE-4GB.c b/src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-H9HCNNNCPMMLXR-NEE-4GB.c new file mode 100644 index 0000000..cf5c4d2 --- /dev/null +++ b/src/mainboard/google/kukui/sdram_params/sdram-lpddr4x-H9HCNNNCPMMLXR-NEE-4GB.c @@ -0,0 +1,26 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <soc/emi.h> + +struct sdram_params params = { + .source = DRAMC_PARAM_SOURCE_SDRAM_CONFIG, + .frequency = 1600, + .wr_level = { + [CHANNEL_A] = { {0x22, 0x1b}, {0x22, 0x19} }, + [CHANNEL_B] = { {0x24, 0x20}, {0x25, 0x20} } + }, + .cbt_cs_dly = { + [CHANNEL_A] = {0x0, 0x0}, + [CHANNEL_B] = {0x0, 0x0} + }, + .cbt_final_vref = { + [CHANNEL_A] = {0x52, 0x52}, + [CHANNEL_B] = {0x52, 0x52} + }, + .emi_cona_val = 0xF053F154, + .emi_conh_val = 0x44440003, + .emi_conf_val = 0x00421000, + .chn_emi_cona_val = {0x0444F051, 0x0444F051}, + .cbt_mode_extern = CBT_NORMAL_MODE, + .delay_cell_unit = 868, +};