Attention is currently required from: Kyösti Mälkki.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63480 )
Change subject: cpu/x86/smm_module_loader: Drop superfluous checks
......................................................................
Patch Set 22:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63480/comment/680103cc_047d2e78
PS20, Line 10: parts of the code.
No need to describe it in commit message, but if you could add a gerrit review comments inline where the checks are now, please.
It's done in the code that sets up everything (l430 in this CL).
Also one of the next patches checks for overlaps on everything so it's certainly covered by that.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63480
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I275d5dda9c69cc89608450ae27dd5dbd581e3595
Gerrit-Change-Number: 63480
Gerrit-PatchSet: 22
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Wed, 01 Jun 2022 11:10:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment