Attention is currently required from: Michał Żygowski, Michał Kopeć, Michael Niewöhner. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62498 )
Change subject: mb/clevo/tgl-u: Add Clevo NV41 Tiger Lake laptop support ......................................................................
Patch Set 1:
(2 comments)
File src/mainboard/clevo/tgl-u/variants/nv4x/gpio.c:
https://review.coreboot.org/c/coreboot/+/62498/comment/e945be0b_b5b5b404 PS1, Line 242: static const struct pad_config early_gpio_table[] = { : PAD_CFG_NF(GPP_C20, UP_20K, DEEP, NF1), /* UART2_RXD */ : PAD_CFG_NF(GPP_C21, UP_20K, DEEP, NF1), /* UART2_TXD */ : PAD_CFG_TERM_GPO(GPP_U4, 0, NONE, DEEP), /* DGPU_RST#_PCH */ : PAD_CFG_TERM_GPO(GPP_U5, 0, NONE, DEEP), /* DGPU_PWR_EN */ : };
Move this to early_gpio. […]
Please use gpio_early.c, to align with the other Clevos.
https://review.coreboot.org/c/coreboot/+/62498/comment/39476174_74086b6a PS1, Line 255: const struct pad_config *variant_early_gpio_table(size_t *num) : { : *num = ARRAY_SIZE(early_gpio_table); : return early_gpio_table; : }
See clevo/cml-u/variants/l140cu/romstage.c how we do GPIO configuration there.
I meant clevo/cml-u/variants/l140cu/gpio_early.c, sorry.