Attention is currently required from: Brandon Weeks, Joel Linn.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81595?usp=email )
Change subject: mb/cwwk: Add CWWK CW-ADL-4L-V2.0 board ......................................................................
Patch Set 4: Code-Review+1
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81595/comment/07a03947_494cad70 : PS2, Line 12: - DisplayPort / HDMI
VBT was extracted from the vendor UEFI firmware.
It’d be great if you documented that (also UEFI firmware version).
https://review.coreboot.org/c/coreboot/+/81595/comment/a71bf606_87913ad8 : PS2, Line 21:
I believe at least S0ix is working but digging into ACPI and Linux power management is where I ran o […]
Feel free to update the commit message accordingly, or just ignore, and mark as resolved.
Commit Message:
https://review.coreboot.org/c/coreboot/+/81595/comment/ae975e76_40a14d60 : PS4, Line 26: Linux It’s always helpful to also document the used Linux version.
Patchset:
PS4: As this boots GNU/Linux this should get submitted soon, and the rest be fixed in follow-ups. Great work. Feel free to ignore my nitpicks.