Attention is currently required from: Arthur Heymans, Christian Walter, Cliff Huang, Johnny Lin, Jonathan Zhang, Lance Zhao, Lean Sheng Tan, Shuo Liu, Tim Chu, Tim Wawrzynczak.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81375?usp=email )
Change subject: acpi: Add soc_acpigen_write_OSC_pci_domain
......................................................................
Patch Set 8: Code-Review+1
(4 comments)
File src/acpi/acpigen_pci.c:
https://review.coreboot.org/c/coreboot/+/81375/comment/050f5725_8429123e :
PS8, Line 164:
`OSC_RET_UNRECOGNIZED_REV` is unused and check for Arg1 is missing.
https://review.coreboot.org/c/coreboot/+/81375/comment/186d7f92_a63799b3 :
PS8, Line 229: RETE
RETE is always 0 here, no need to or OSC_RET_FAILURE with it.
`acpigen_write_store_int_to_namestr(OSC_RET_FAILURE, "RETE");`
https://review.coreboot.org/c/coreboot/+/81375/comment/337570f5_eb051801 :
PS8, Line 291: acpigen_write_to_integer_from_namestring
RETE is always 0 here, no need to or OSC_RET_FAILURE with it.
`acpigen_write_store_int_to_namestr(OSC_RET_FAILURE, "RETE");`
https://review.coreboot.org/c/coreboot/+/81375/comment/857514ad_97cef795 :
PS8, Line 328: acpigen_emit_byte
You can emit the namestring directly without using a local variable.
```
acpigen_emit_namestring("CTRC");
acpigen_emit_namestring("OTRC");
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81375?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I711ce5350d718e47feb2912555108801ad7f918d
Gerrit-Change-Number: 81375
Gerrit-PatchSet: 8
Gerrit-Owner: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Mon, 25 Mar 2024 07:05:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment